src/goModifytags: support gomodifytags's --template flag #826

perrito666 · 2020-10-22T17:52:06Z

Support gomodifytags 1.11.0 new --template feature

As of 1.11.0 there is a --template option in gomofidytags that allows to give a special formatting to the tags, this adds support to it.

as of [1.11.0](https://github.com/fatih/gomodifytags/releases/tag/v1.11.0) there is a `--template` option in gomofidytags tha allows to give a special formatting to the tags, this adds support to it.

gopherbot · 2020-10-22T17:59:11Z

This PR (HEAD: eedcd27) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/264299 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-22T18:05:01Z

This PR (HEAD: e855d50) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/264299 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-22T18:13:14Z

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-22T18:26:10Z

Message from Horacio Duran:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-22T18:58:12Z

Message from Horacio Duran:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-22T19:37:26Z

Message from Horacio Duran:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-22T21:09:48Z

Message from Hyang-Ah Hana Kim:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

if the version of gomodifytags does not have --template (we try to infer that) let the user know and prompt for update.

gopherbot · 2020-10-22T21:29:44Z

This PR (HEAD: 2bff476) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/264299 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-22T21:33:40Z

Message from Horacio Duran:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-22T21:35:44Z

This PR (HEAD: 9083554) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/264299 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-30T14:52:26Z

Message from Hyang-Ah Hana Kim:

Patch Set 6: Run-TryBot+1 Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-30T14:56:24Z

Message from kokoro:

Patch Set 6:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b9ec9ba1-0876-4189-b2f7-688125497587

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

This was an accidental commit

gopherbot · 2020-10-30T14:58:21Z

This PR (HEAD: 0e3e70d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/264299 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

I am doing this on the web and for some reason it keeps adding the line

gopherbot · 2020-10-30T15:02:24Z

This PR (HEAD: b26a2a6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/264299 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-30T15:26:09Z

Message from Horacio Duran:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-30T15:44:21Z

Message from Hyang-Ah Hana Kim:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-30T17:56:15Z

Message from kokoro:

Patch Set 6: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/b9ec9ba1-0876-4189-b2f7-688125497587

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-30T20:32:52Z

Message from Hyang-Ah Hana Kim:

Patch Set 8: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

Support gomodifytags 1.11.0 new --template feature As of [1.11.0](https://github.com/fatih/gomodifytags/releases/tag/v1.11.0) there is a `--template` option in gomofidytags that allows to give a special formatting to the tags, this adds support to it. Change-Id: I94949bbfa87941a4b04b5671e728442a849e0e5e GitHub-Last-Rev: b26a2a6 GitHub-Pull-Request: #826 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/264299 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Suzy Mueller <[email protected]> Trust: Suzy Mueller <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]>

gopherbot · 2020-11-02T21:32:58Z

Message from Suzy Mueller:

Patch Set 8: Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/264299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-02T21:34:58Z

This PR is being closed because golang.org/cl/264299 has been merged.

Add support for gomodifytags --template

3e5a004

as of [1.11.0](https://github.com/fatih/gomodifytags/releases/tag/v1.11.0) there is a `--template` option in gomofidytags tha allows to give a special formatting to the tags, this adds support to it.

google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 22, 2020

I think I should not push this file

eedcd27

Correct Lint errors

e855d50

perrito666 changed the title ~~Add vscode support for gomodifytags --template~~ support gomodifytags's --template flag Oct 22, 2020

perrito666 changed the title ~~support gomodifytags's --template flag~~ src/goModifytags: support gomodifytags's --template flag Oct 22, 2020

Add useful error on wrong version

2bff476

if the version of gomodifytags does not have --template (we try to infer that) let the user know and prompt for update.

Correct linting

9083554

hyangah added this to the v0.19.0 milestone Oct 30, 2020

perrito666 added 2 commits October 30, 2020 11:56

Remove accidental commit

abebbb9

This was an accidental commit

Remove newline

0e3e70d

Try 2 to remove newline at the end

b26a2a6

I am doing this on the web and for some reason it keeps adding the line

gopherbot closed this Nov 2, 2020

src/goModifytags: support gomodifytags's --template flag #826

src/goModifytags: support gomodifytags's --template flag #826

Uh oh!

Conversation

perrito666 commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 22, 2020

Uh oh!

gopherbot commented Oct 30, 2020

Uh oh!

gopherbot commented Oct 30, 2020

Uh oh!

gopherbot commented Oct 30, 2020

Uh oh!

gopherbot commented Oct 30, 2020

Uh oh!

gopherbot commented Oct 30, 2020

Uh oh!

gopherbot commented Oct 30, 2020

Uh oh!

gopherbot commented Oct 30, 2020

Uh oh!

gopherbot commented Oct 30, 2020

Uh oh!

gopherbot commented Nov 2, 2020

Uh oh!

gopherbot commented Nov 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants