Skip to content

Conversation

@rogeryk
Copy link
Contributor

@rogeryk rogeryk commented Nov 13, 2023

There is an extra quote in the command, which should be an error.

There is an extra quote in the command, which should be an error.
@gopherbot
Copy link
Collaborator

This PR (HEAD: 703b7a1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/541875.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from qiulaidongfeng:

Patch Set 1: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/541875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/541875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Robert Findley:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/541875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/541875.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/ecd3c702-7cef-4075-986b-2aad257a52d3


Please don’t reply on this GitHub thread. Visit golang.org/cl/541875.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 22, 2023
There is an extra quote in the command, which should be an error.

Change-Id: I6ff7c00fa7cacaaef9476232637bff110647ff40
GitHub-Last-Rev: 703b7a1
GitHub-Pull-Request: #3042
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/541875
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Auto-Submit: Hyang-Ah Hana Kim <[email protected]>
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/541875 has been merged.

@gopherbot gopherbot closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants