all: fix typos #53
Open
all: fix typos #53
+28
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR (HEAD: 2539278) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/145739 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit User 5206: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/145739. |
|
This PR (HEAD: 21306c4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/145739 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit User 5206: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/145739. |
|
Message from Gerrit User 5976: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=2f8b0713 Please don’t reply on this GitHub thread. Visit golang.org/cl/145739. |
|
Message from Gerrit User 5976: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/145739. |
|
Message from Gerrit User 29494: Patch Set 2: (3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/145739. |
hartzell
added a commit
to hartzell/tools
that referenced
this pull request
Sep 13, 2019
This commit adds support for calling rename from the gopls command line, e.g. $ gopls rename -w ~/tmp/foo/main.go:8:6 $ gopls rename -w ~/tmp/foo/main.go:golang#53 Optional arguments are: - -w, which writes the changes back to the original file; and - -d, which prints a unified diff to stdout With no arguments, the contens of the changed files are printed to stdout. It: - adds internal/lsp/cmd/rename.go, which implements the command; - adds "rename" to the list of commands in internal/lsp/cmd/cmd.go; - removes the dummy test from internal/lsp/cmd/cmd_test.go; and - adds internal/lsp/cmd/rename_test.go, which uses the existing - "golden" data to implement its tests. Updates #32875
hartzell
added a commit
to hartzell/tools
that referenced
this pull request
Sep 16, 2019
This commit adds support for calling rename from the gopls command line, e.g. $ gopls rename -w ~/tmp/foo/main.go:8:6 $ gopls rename -w ~/tmp/foo/main.go:golang#53 Optional arguments are: - -w, which writes the changes back to the original file; and - -d, which prints a unified diff to stdout With no arguments, the contens of the changed files are printed to stdout. It: - adds internal/lsp/cmd/rename.go, which implements the command; - adds "rename" to the list of commands in internal/lsp/cmd/cmd.go; - removes the dummy test from internal/lsp/cmd/cmd_test.go; and - adds internal/lsp/cmd/rename_test.go - which uses the existing "golden" data to implement basic tests - adds "golden" data for the diff tests. Updates #32875
hartzell
added a commit
to hartzell/tools
that referenced
this pull request
Sep 20, 2019
This commit adds support for calling rename from the gopls command line, e.g. $ gopls rename -w ~/tmp/foo/main.go:8:6 $ gopls rename -w ~/tmp/foo/main.go:golang#53 Optional arguments are: - -w, which writes the changes back to the original file; and - -d, which prints a unified diff to stdout With no arguments, the contens of the changed files are printed to stdout. It: - adds internal/lsp/cmd/rename.go, which implements the command; - adds "rename" to the list of commands in internal/lsp/cmd/cmd.go; - removes the dummy test from internal/lsp/cmd/cmd_test.go; and - adds internal/lsp/cmd/rename_test.go - which uses the existing "golden" data to implement basic tests - adds "golden" data for the diff tests. Updates #32875
hartzell
added a commit
to hartzell/tools
that referenced
this pull request
Sep 20, 2019
This commit adds support for calling rename from the gopls command line, e.g. $ gopls rename -w ~/tmp/foo/main.go:8:6 $ gopls rename -w ~/tmp/foo/main.go:golang#53 Optional arguments are: - -w, which writes the changes back to the original file; and - -d, which prints a unified diff to stdout With no arguments, the contens of the changed files are printed to stdout. It: - adds internal/lsp/cmd/rename.go, which implements the command; - adds "rename" to the list of commands in internal/lsp/cmd/cmd.go; - removes the dummy test from internal/lsp/cmd/cmd_test.go; and - adds internal/lsp/cmd/rename_test.go - which uses the existing "golden" data to implement basic tests - adds "golden" data for the diff tests. Updates #32875
gopherbot
pushed a commit
that referenced
this pull request
Sep 20, 2019
This commit adds support for calling rename from the gopls command line, e.g. $ gopls rename -w ~/tmp/foo/main.go:8:6 $ gopls rename -w ~/tmp/foo/main.go:#53 Optional arguments are: - -w, which writes the changes back to the original file; and - -d, which prints a unified diff to stdout With no arguments, the changed files are printed to stdout. It: - adds internal/lsp/cmd/rename.go, which implements the command; - adds "rename" to the list of commands in internal/lsp/cmd/cmd.go; - removes the dummy test from internal/lsp/cmd/cmd_test.go; and - adds internal/lsp/cmd/rename_test.go, which uses the existing "golden" data to implement its tests. Updates #32875 Change-Id: I5cab5a40b4aa26357b26b0caf4ed54dbd2284d0f GitHub-Last-Rev: fe853d3 GitHub-Pull-Request: #157 Reviewed-on: https://go-review.googlesource.com/c/tools/+/194878 Run-TryBot: Ian Cottrell <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Cottrell <[email protected]>
clintjedwards
pushed a commit
to clintjedwards/tools
that referenced
this pull request
Sep 25, 2019
This commit adds support for calling rename from the gopls command line, e.g. $ gopls rename -w ~/tmp/foo/main.go:8:6 $ gopls rename -w ~/tmp/foo/main.go:golang#53 Optional arguments are: - -w, which writes the changes back to the original file; and - -d, which prints a unified diff to stdout With no arguments, the changed files are printed to stdout. It: - adds internal/lsp/cmd/rename.go, which implements the command; - adds "rename" to the list of commands in internal/lsp/cmd/cmd.go; - removes the dummy test from internal/lsp/cmd/cmd_test.go; and - adds internal/lsp/cmd/rename_test.go, which uses the existing "golden" data to implement its tests. Updates #32875 Change-Id: I5cab5a40b4aa26357b26b0caf4ed54dbd2284d0f GitHub-Last-Rev: fe853d3 GitHub-Pull-Request: golang#157 Reviewed-on: https://go-review.googlesource.com/c/tools/+/194878 Run-TryBot: Ian Cottrell <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Cottrell <[email protected]>
gopherbot
pushed a commit
that referenced
this pull request
Oct 25, 2019
This change adds command line support for references. Example: $ gopls references ~/tmp/foo/main.go:8:6 $ gopls references ~/tmp/foo/main.go:#53 Updates golang/go#32875 Change-Id: I9a0cf6ae8ba0a5c3d4ffc829b96fe3b42297c192 Reviewed-on: https://go-review.googlesource.com/c/tools/+/202178 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>
gopherbot
pushed a commit
that referenced
this pull request
Nov 25, 2019
This change adds command line support for implementation. Example: $ gopls implementation ~/tmp/foo/main.go:8:6 $ gopls implementation ~/tmp/foo/main.go:#53 Updates golang/go#32875 Change-Id: I3aa89a788ded886368b07c1824325069f3cba88a Reviewed-on: https://go-review.googlesource.com/c/tools/+/208357 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.