Skip to content

gopls: use slices package for reverse slice #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gopls: use slices package for reverse slice #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f6c5cd
gopls: use slices package for reverse slice
Zxilly Mar 16, 2024
fc1d59d
fix test cases
Zxilly Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions gopls/internal/golang/completion/postfix_snippets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,8 @@ var postfixTmpls = []postfixTmpl{{
label: "reverse",
details: "reverse slice",
body: `{{if and (eq .Kind "slice") .StmtOK -}}
{{$i := .VarName nil "i"}}{{$j := .VarName nil "j" -}}
for {{$i}}, {{$j}} := 0, len({{.X}})-1; {{$i}} < {{$j}}; {{$i}}, {{$j}} = {{$i}}+1, {{$j}}-1 {
{{.X}}[{{$i}}], {{.X}}[{{$j}}] = {{.X}}[{{$j}}], {{.X}}[{{$i}}]
}
{{end}}`,
{{.Import "slices"}}.Reverse({{.X}})
{{- end}}`,
}, {
label: "range",
details: "range over slice",
Expand Down
7 changes: 3 additions & 4 deletions gopls/internal/test/integration/completion/postfix_snippet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,11 @@ func _() {
after: `
package foo

import "slices"

func _() {
var foo []int
for i, j := 0, len(foo)-1; i < j; i, j = i+1, j-1 {
foo[i], foo[j] = foo[j], foo[i]
}

slices.Reverse(foo)
}
`,
},
Expand Down
2 changes: 1 addition & 1 deletion gopls/internal/test/marker/testdata/completion/postfix.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func _() {
foo.len //@snippet(" //", postfixLen, "len(foo)")
foo.print //@snippet(" //", postfixPrint, `fmt.Printf("foo: %v\n", foo)`)
foo.rang //@snippet(" //", postfixRange, "for ${1:}, ${2:} := range foo {\n\t$0\n}")
foo.reverse //@snippet(" //", postfixReverse, "for i, j := 0, len(foo)-1; i < j; i, j = i+1, j-1 {\n\tfoo[i], foo[j] = foo[j], foo[i]\n}\n")
foo.reverse //@snippet(" //", postfixReverse, "slices.Reverse(foo)")
foo.sort //@snippet(" //", postfixSort, "sort.Slice(foo, func(i, j int) bool {\n\t$0\n})")
foo.va //@snippet(" //", postfixVar, "${1:} := foo")
foo.ifnotnil //@snippet(" //", postfixIfNotNil, "if foo != nil {\n\t$0\n}")
Expand Down