-
Notifications
You must be signed in to change notification settings - Fork 2.3k
gopls: use slices package for reverse slice #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 6f6c5cd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/572116. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Zxilly Chou: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Alan Donovan: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Robert Findley: Patch Set 2: Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-18T19:55:15Z","revision":"91a230b443ce4ca789576baadbe5e71d12930270"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Robert Findley: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Failed Tryjobs: FAILURE
Error: Links:
FAILURE
Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Robert Findley: Patch Set 2: -Code-Review (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Alan Donovan: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Alan Donovan: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
This PR (HEAD: fc1d59d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/572116. Important tips:
|
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Robert Findley: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-19T00:44:38Z","revision":"d1cff179ee6271603fd0633577bd8bfcfcb73ec3"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Robert Findley: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
Message from David Chase: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572116. |
slices has been supported in go1.21 and go1.22 Fixes golang/go#66222 Change-Id: I7b319e649632a713200dcaabd1e68d1f01e1b2f2 GitHub-Last-Rev: fc1d59d GitHub-Pull-Request: #484 Reviewed-on: https://go-review.googlesource.com/c/tools/+/572116 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: David Chase <[email protected]> Reviewed-by: Alan Donovan <[email protected]>
This PR is being closed because golang.org/cl/572116 has been merged. |
slices has been supported in go1.21 and go1.22
Fixes golang/go#66222