internal/lsp/source: fix Deref function for cyclic types #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ShoshinNikita wants to merge 1 commit into golang:master from ShoshinNikita:fix-deref-for-cyclic-types

Contributor

ShoshinNikita commented Apr 16, 2021

The previous fix (d1362d7) is not sufficient for all cyclic types.
This change updates Deref function to support more complex cases.
We use a map with underlying types to detect cycles.

Fixes golang/go#45510


          internal/lsp/source: fix Deref function for cyclic types

4c89874

The previous fix (d1362d7) is not sufficient for all cyclic types.
This change updates Deref function to support more complex cases.
We use a map with underlying types to detect cycles.

Fixes golang/go#45510

google-cla bot added the cla: yes label

Contributor

gopherbot commented Apr 16, 2021

This PR (HEAD: 4c89874) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/310311 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Apr 16, 2021

Message from Rebecca Stambler:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/310311.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 16, 2021

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=aa8a729e

Please don’t reply on this GitHub thread. Visit golang.org/cl/310311.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 16, 2021

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/18d73212-66f2-4a68-8399-1e7b60e6dac1

Please don’t reply on this GitHub thread. Visit golang.org/cl/310311.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 16, 2021

Message from Robert Findley:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/310311.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 16, 2021

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/18d73212-66f2-4a68-8399-1e7b60e6dac1

Please don’t reply on this GitHub thread. Visit golang.org/cl/310311.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 16, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/310311.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          internal/lsp/source: fix Deref function for cyclic types

fe50371

The previous fix (d1362d7) is not sufficient for all cyclic types.
This change updates Deref function to support more complex cases.
We use a map with underlying types to detect cycles.

Fixes golang/go#45510

Change-Id: I28f655a9c1d4f363cb7ae3f47db3e8567fe6e80a
GitHub-Last-Rev: 4c89874
GitHub-Pull-Request: #305
Reviewed-on: https://go-review.googlesource.com/c/tools/+/310311
Reviewed-by: Rebecca Stambler <[email protected]>
Trust: Rebecca Stambler <[email protected]>
Trust: Robert Findley <[email protected]>
Run-TryBot: Rebecca Stambler <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Go Bot <[email protected]>

Contributor

gopherbot commented Apr 16, 2021

This PR is being closed because golang.org/cl/310311 has been merged.

gopherbot closed this

ShoshinNikita deleted the fix-deref-for-cyclic-types branch

April 16, 2021 18:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels