Skip to content

internal/lsp: fixed a bug where GOPROXY was set to GOROOT #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

internal/lsp: fixed a bug where GOPROXY was set to GOROOT #152

wants to merge 1 commit into from

Conversation

zoumo
Copy link
Contributor

@zoumo zoumo commented Sep 8, 2019 •
edited
Loading

No description provided.

@zoumo
Copy link
Contributor Author

zoumo commented Sep 8, 2019

/cc @suzmue

@gopherbot
Copy link
Contributor

This PR (HEAD: 21c19aa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/194197 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Cottrell:

Patch Set 1: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/194197.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=78e43ed4

Please don’t reply on this GitHub thread. Visit golang.org/cl/194197.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/194197.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 9, 2019
@zoumo @stamblerre
internal/lsp: fixed a bug where GOPROXY was set to GOROOT
81ca6dc 
Change-Id: I29802f65be1f048a43b0b016051d64d400040fe9
GitHub-Last-Rev: 21c19aa
GitHub-Pull-Request: #152
Reviewed-on: https://go-review.googlesource.com/c/tools/+/194197
Reviewed-by: Ian Cottrell <[email protected]>
Run-TryBot: Ian Cottrell <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/194197 has been merged.

@gopherbot gopherbot closed this Sep 9, 2019
@zoumo zoumo deleted the lsp branch September 3, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoumo @gopherbot @googlebot