Delete the conformance test #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
force-pushed
the
delete-conformance
branch
from
3b95ddf to
5ac1165
Compare
|
\cc @bcmills |
The conformance test is hard to run and heavily dependant on the exact version of protoc installed on the developer's workstation. Delete this from the v1 and leave conformance testing to v2, which has infrastructure built for stricter control over dependencies.
dsnet
force-pushed
the
delete-conformance
branch
from
5ac1165 to
d43ac14
Compare
bcmills
approved these changes
Feb 28, 2019
This was referenced Feb 28, 2019
Closed
dsnet
added a commit
that referenced
this pull request
Mar 11, 2019
This merges in the following upstream PRs: * #797: ptypes: More cleanly construct a Timestamp * #796: ptypes: Avoid assuming time.Duration is nanoseconds * #805: proto: remove test dependency on experimental packages * #808: Delete the conformance test Change-Id: I104189682bbc0a18e3d8460e57f9fcb45f1f4a46 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/166521 Reviewed-by: Herbie Ong <[email protected]>
willnewrelic
pushed a commit
to newrelic/go-agent
that referenced
this pull request
Jan 27, 2020
protobuf cleaned up their go.mod file between v1.3.0 and v1.3.1 in golang/protobuf#805 and golang/protobuf#808.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conformance test is hard to run and heavily dependant on the exact
version of protoc installed on the developer's workstation.
Delete this from v1 and leave conformance testing to v2,
which has infrastructure built for stricter control over dependencies.