Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

check error for os.Setenv in parse_test.go #472

Merged
merged 3 commits into from
Aug 18, 2020
Merged

check error for os.Setenv in parse_test.go #472

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ccc686
check error for os.Setenv in parse_test.go
antcs Aug 17, 2020
25d1a55
print key, value and error in t.Errorf()
antcs Aug 18, 2020
3d69240
error assignment and handling in one line
antcs Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions mockgen/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ func TestParsePackageImport(t *testing.T) {
} {
t.Run(testCase.name, func(t *testing.T) {
for key, value := range testCase.envs {
os.Setenv(key, value)
if err := os.Setenv(key, value); err != nil {
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
}
}
pkgPath, err := parsePackageImport(filepath.Clean(testCase.dir))
if err != testCase.err {
Expand Down Expand Up @@ -195,8 +197,16 @@ func TestParsePackageImport_FallbackGoPath(t *testing.T) {
if err != nil {
t.Error(err)
}
os.Setenv("GOPATH", goPath)
os.Setenv("GO111MODULE", "on")
key := "GOPATH"
value := goPath
if err := os.Setenv(key, value); err != nil {
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
}
key = "GO111MODULE"
value = "on"
if err := os.Setenv(key, value); err != nil {
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
}
pkgPath, err := parsePackageImport(srcDir)
expected := "example.com/foo"
if pkgPath != expected {
Expand Down Expand Up @@ -237,8 +247,16 @@ func TestParsePackageImport_FallbackMultiGoPath(t *testing.T) {
}()

goPaths := strings.Join(goPathList, string(os.PathListSeparator))
os.Setenv("GOPATH", goPaths)
os.Setenv("GO111MODULE", "on")
key := "GOPATH"
value := goPaths
if err := os.Setenv(key, value); err != nil {
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
}
key = "GO111MODULE"
value = "on"
if err := os.Setenv(key, value); err != nil {
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
}
pkgPath, err := parsePackageImport(srcDir)
expected := "example.com/foo"
if pkgPath != expected {
Expand Down