-
Notifications
You must be signed in to change notification settings - Fork 18.4k
hash/crc32: fix incorrect checksums with avx512+race #74775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…with avx512+race Fixes golang#74767 CRC value loaded from incorrect register, which happened to line up with actual register on default compile. Therefore failures would only show up with `-race`. Adds regression test with longer payloads. Fix regression from CL/689435 - golang#74701 - 18dbe5b Change-Id: Ib63ddade998a5630297b285f3d566361f36f28e5
This PR (HEAD: 5074012) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690855. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/690855. |
Message from t hepudds: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/690855. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-28T15:29:33Z","revision":"6b1b4b19f1ac45cf9206b608bd28546243d0c5b5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/690855. |
Message from Keith Randall: Patch Set 4: Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/690855. |
Message from Keith Randall: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/690855. |
Message from David Chase: Patch Set 4: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/690855. |
CRC value loaded from incorrect register, which happened to line up with actual register on default compile. Therefore failures would only show up with -race. Add regression test with longer payloads. Fix regression from CL 689435. Fixes #74767. Change-Id: Ib63ddade998a5630297b285f3d566361f36f28e5 GitHub-Last-Rev: 5074012 GitHub-Pull-Request: #74775 Reviewed-on: https://go-review.googlesource.com/c/go/+/690855 Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Keith Randall <[email protected]> Reviewed-by: David Chase <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/690855 has been merged. |
CRC value loaded from incorrect register, which happened
to line up with actual register on default compile.
Therefore failures would only show up with -race.
Add regression test with longer payloads.
Fix regression from CL 689435.
Fixes #74767.