-
Notifications
You must be signed in to change notification settings - Fork 18.4k
plugin: include a warning about race detector compatability in docs #68792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tation As described in golang#24245, the race detector isn't able to find some race conditions in plugins. This commit adds a warning about this to the plugins documentation. Updates golang#24245
This PR (HEAD: eb3f646) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604275. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604275. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/604275. |
Message from Ian Lance Taylor: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604275. |
In response to feedback from Ian Lance Taylor
This PR (HEAD: a5b4ff4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604275. Important tips:
|
Message from Ezra Newman: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604275. |
Message from Ian Lance Taylor: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604275. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-09T19:33:06Z","revision":"1f09f01e4deeac82a1cbcf8232ec7d49b1f5386b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/604275. |
As described in #24245, the race detector isn't able to find some race conditions in plugins. This commit adds a warning about this to the plugins documentation. Updates #24245 Change-Id: I1a5ab9b5e22b6a254efc639c3c03f75b79214d49 GitHub-Last-Rev: a5b4ff4 GitHub-Pull-Request: #68792 Reviewed-on: https://go-review.googlesource.com/c/go/+/604275 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Message from Cherry Mui: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/604275. |
This PR is being closed because golang.org/cl/604275 has been merged. |
As described in #24245, the race detector isn't able to find some race conditions in plugins.
This commit adds a warning about this to the plugins documentation.
Updates #24245