-
Notifications
You must be signed in to change notification settings - Fork 18k
expvar: avoid conflict with user-defined "GET /" route. #65745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: ff3d530) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564735. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Matteo Vaccari: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Jonathan Amsterdam: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
This PR (HEAD: 5f21a97) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564735. Important tips:
|
This PR (HEAD: affeacd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564735. Important tips:
|
Message from Gopher Robot: Patch Set 4: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
This PR (HEAD: c7dae83) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564735. Important tips:
|
Message from Matteo Vaccari: Patch Set 5: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
With the new routing style in go 1.22, declaring http.Handle("GET /", h) generates a conflict with route "/debug/vars" declared in the expvar package. You get an error such as: panic: pattern "GET /" (registered at ...) conflicts with pattern "/debug/vars" (registered at ...expvar.go:384): GET / matches fewer methods than /debug/vars, but has a more general path pattern This patch prevents that error. Adding GET is correct because no other method makes sense with /debug/vars. However, a tool using any other methods will break. We preserve the traditional behaviour when GODEBUG=httpmuxgo121=1 is specified. Fixes golang#65723
This PR (HEAD: 2322758) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564735. Important tips:
|
This PR (HEAD: 9c2b9f7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564735. Important tips:
|
Message from Jonathan Amsterdam: Patch Set 7: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Matteo Vaccari: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Damien Neil: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Jonathan Amsterdam: Patch Set 7: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-26T11:57:49Z","revision":"ec2e1caa17671cfe4a5cbc2ae5ce7dc74ae3ad83"} Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Jonathan Amsterdam: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564735. |
With the new routing style in go 1.22, declaring http.Handle("GET /", h) generates a conflict with route "/debug/vars" declared in the expvar package. You get an error such as: panic: pattern "GET /" (registered at ...) conflicts with pattern "/debug/vars" (registered at ...expvar.go:384): GET / matches fewer methods than /debug/vars, but has a more general path pattern This patch prevents that error. Adding GET is correct because no other method makes sense with /debug/vars. We preserve the traditional behaviour when GODEBUG=httpmuxgo121=1 is specified. Fixes #65723 Change-Id: Id2b963ebad41a1ebdcceb73baf3436d59aac73a0 GitHub-Last-Rev: 9c2b9f7 GitHub-Pull-Request: #65745 Reviewed-on: https://go-review.googlesource.com/c/go/+/564735 Reviewed-by: Damien Neil <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
This PR is being closed because golang.org/cl/564735 has been merged. |
With the new routing style in go 1.22, declaring
generates a conflict with route "/debug/vars" declared in the expvar
package. You get an error such as:
panic: pattern "GET /" (registered at ...) conflicts with pattern
"/debug/vars" (registered at ...expvar.go:384): GET / matches fewer
methods than /debug/vars, but has a more general path pattern
This patch prevents that error. Adding GET is correct because no other
method makes sense with /debug/vars.
We preserve the traditional behaviour when GODEBUG=httpmuxgo121=1 is
specified.
Fixes #65723