cmd/go/internal/vcs: use git log to avoid unnecessary objects #65341

huww98 · 2024-01-29T06:27:15Z

"git show" by default shows the diff from the previous commit. "-s"
suppress all output from the diff machinery. But it will still try to
fetch the relevant objects, which may be unavailable if the repository
is a partial clone.

Use "git log" instead, which only needs the commit object.

Fixes #65339

gopherbot · 2024-01-29T06:33:29Z

This PR (HEAD: 71a2138) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/559075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-29T06:39:22Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T06:39:22Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T06:45:27Z

Message from 胡玮文:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T06:51:34Z

This PR (HEAD: 86e501c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/559075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-29T08:49:46Z

Message from qiulaidongfeng:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T08:49:47Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T09:02:04Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T21:02:36Z

Message from Bryan Mills:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-30T07:18:26Z

This PR (HEAD: d2bd52d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/559075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-30T07:24:26Z

Message from 胡玮文:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-30T07:57:15Z

This PR (HEAD: 262e712) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/559075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-30T12:18:49Z

Message from 胡玮文:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-06T04:05:44Z

Message from 胡玮文:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T13:44:54Z

Message from qiulaidongfeng:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T13:44:55Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-08T13:32:32Z","revision":"36ff30c8566955afec37a9a1de0d9b0c2bd715e5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T13:44:55Z

Message from qiulaidongfeng:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T13:44:56Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 559075)
tools on master (commit f4fa7a7)

Error:
failed to run "test golang.org/x/tools module": exit status 1
failed to run "test golang.org/x/tools/gopls module": exit status 1

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T13:44:56Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T14:18:55Z

Message from 胡玮文:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T14:18:56Z

Message from qiulaidongfeng:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T14:32:35Z

This PR (HEAD: 5d68d45) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/559075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-08T15:06:35Z

Message from 胡玮文:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T01:02:55Z

Message from qiulaidongfeng:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T01:09:00Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-09T00:58:18Z","revision":"3abc3c2206ebb2e7f286df8d564169a1c3f7b8e5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T01:33:11Z

Message from qiulaidongfeng:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T01:33:11Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T01:33:12Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T22:38:13Z

Message from Bryan Mills:

Patch Set 6: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T22:38:13Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-21T22:33:46Z","revision":"3abc3c2206ebb2e7f286df8d564169a1c3f7b8e5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T22:57:04Z

Message from Bryan Mills:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-21T22:57:05Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

"git show" by default shows the diff from the previous commit. "-s" suppress all output from the diff machinery. But it will still try to fetch the relevant objects, which may be unavailable if the repository is a partial clone. Use "git log" instead, which only needs the commit object. Fixes golang#65339

gopherbot · 2024-02-22T03:10:52Z

This PR (HEAD: 87a8ba4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/559075.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T03:22:37Z

Message from 胡玮文:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T22:11:35Z

Message from Bryan Mills:

Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T22:17:36Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-22T22:04:57Z","revision":"7f053666934078e01516cd392a4cd11272bfebce"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T22:37:19Z

Message from Bryan Mills:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T22:37:20Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T22:37:21Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T00:41:58Z

Message from 胡玮文:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-28T21:05:58Z

Message from Bryan Mills:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-29T04:13:24Z

Message from 胡玮文:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-29T19:02:13Z

Message from Bryan Mills:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/559075.
After addressing review feedback, remember to publish your drafts!

"git show" by default shows the diff from the previous commit. "-s" suppress all output from the diff machinery. But it will still try to fetch the relevant objects, which may be unavailable if the repository is a partial clone. Use "git log" instead, which only needs the commit object. Fixes #65339 Change-Id: I766a680321cd22d5fdbd08d24cb777ef964bdb7c GitHub-Last-Rev: 87a8ba4 GitHub-Pull-Request: #65341 Reviewed-on: https://go-review.googlesource.com/c/go/+/559075 Auto-Submit: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>

gopherbot · 2024-03-04T17:39:49Z

This PR is being closed because golang.org/cl/559075 has been merged.

huww98 force-pushed the git-log branch from 71a2138 to 86e501c Compare January 29, 2024 06:50

huww98 force-pushed the git-log branch from 86e501c to d2bd52d Compare January 30, 2024 07:16

huww98 changed the title ~~cmd/go/internal/vcs: use git log to avoid unnecessary tree object~~ cmd/go/internal/vcs: use git log to avoid unnecessary objects Jan 30, 2024

huww98 force-pushed the git-log branch from d2bd52d to 262e712 Compare January 30, 2024 07:53

huww98 force-pushed the git-log branch from 262e712 to 5d68d45 Compare February 8, 2024 14:28

huww98 force-pushed the git-log branch from 5d68d45 to 87a8ba4 Compare February 22, 2024 03:05

gopherbot closed this Mar 4, 2024

cmd/go/internal/vcs: use git log to avoid unnecessary objects #65341

cmd/go/internal/vcs: use git log to avoid unnecessary objects #65341

Uh oh!

Conversation

huww98 commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 29, 2024

Uh oh!

gopherbot commented Jan 30, 2024

Uh oh!

gopherbot commented Jan 30, 2024

Uh oh!

gopherbot commented Jan 30, 2024

Uh oh!

gopherbot commented Jan 30, 2024

Uh oh!

gopherbot commented Feb 6, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 8, 2024

Uh oh!

gopherbot commented Feb 9, 2024

Uh oh!

gopherbot commented Feb 9, 2024

Uh oh!

gopherbot commented Feb 9, 2024

Uh oh!

gopherbot commented Feb 9, 2024

Uh oh!

gopherbot commented Feb 9, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 21, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

Uh oh!

gopherbot commented Feb 22, 2024

huww98 commented Jan 29, 2024 •

edited

Loading