-
Notifications
You must be signed in to change notification settings - Fork 18.1k
cmd/go/internal/modload: avoid calling strings.HasPrefix twice in *MainModuleSet.DirImportPath #63893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go/internal/modload: avoid calling strings.HasPrefix twice in *MainModuleSet.DirImportPath #63893
Conversation
…et.DirImportPath To avoid calling strings.HasPrefix twice, don't use strings.TrimPrefix.
This PR (HEAD: 74bcfff) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/539096. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Jes Cok: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Jes Cok: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Bryan Mills: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-07T22:21:07Z","revision":"350630de8f7a9e374dafe9ae6cad4252d8a2458b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Bryan Mills: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Go LUCI: Patch Set 4: This CL has failed the run. Reason: Tryjob golang/try/gotip-wasip1-wasm_wasmtime has failed with summary (view all results): FAILURE
error: shard 1: failed to run "go tool dist test -json": exit status 1
Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/539096. |
…inModuleSet.DirImportPath Since TrimPrefix uses HasPrefix internally. Change-Id: Ifadb99dd9192578056636adacaccc9d88a1c1f32 GitHub-Last-Rev: 74bcfff GitHub-Pull-Request: #63893 Reviewed-on: https://go-review.googlesource.com/c/go/+/539096 Run-TryBot: Jes Cok <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
This PR is being closed because golang.org/cl/539096 has been merged. |
Since TrimPrefix uses HasPrefix internally.