cmd/go/internal/modload: don't use strings.TrimPrefix in *MainModuleSet.DirImportPath

callthingsoff · callthingsoff · commit 74bcfff3fb5e · 2023-11-02T14:53:05.000+08:00
To avoid calling strings.HasPrefix twice, don't use strings.TrimPrefix.
diff --git a/src/cmd/go/internal/modload/load.go b/src/cmd/go/internal/modload/load.go
@@ -777,7 +777,7 @@ func (mms *MainModuleSet) DirImportPath(ctx context.Context, dir string) (path s
 				longestPrefixVersion = v
 				suffix := filepath.ToSlash(str.TrimFilePathPrefix(dir, modRoot))
 				if strings.HasPrefix(suffix, "vendor/") {
-					longestPrefixPath = strings.TrimPrefix(suffix, "vendor/")
+					longestPrefixPath = suffix[len("vendor/"):]
 					continue
 				}
 				longestPrefixPath = pathpkg.Join(mms.PathPrefix(v), suffix)

Original file line number	Diff line number	Diff line change
`@@ -777,7 +777,7 @@ func (mms *MainModuleSet) DirImportPath(ctx context.Context, dir string) (path s`
`777`	`777`	`longestPrefixVersion = v`
`778`	`778`	`suffix := filepath.ToSlash(str.TrimFilePathPrefix(dir, modRoot))`
`779`	`779`	`if strings.HasPrefix(suffix, "vendor/") {`
`780`		`- longestPrefixPath = strings.TrimPrefix(suffix, "vendor/")`
	`780`	`+ longestPrefixPath = suffix[len("vendor/"):]`
`781`	`781`	`continue`
`782`	`782`	`}`
`783`	`783`	`longestPrefixPath = pathpkg.Join(mms.PathPrefix(v), suffix)`