cmd/link: add option to enable full RELRO for ELF #58869

nrvnrvn · 2023-03-04T23:11:05Z

-bindnow linker option enables full RELRO on ELF targets.

This options defaults to false and preserves
current behavior - partial relro for buildmode=pie.

Also, the following changes were made to align
internal linker's behavior with external ELF linkers:

GNU_RELRO segment is marked Read-only
.dynamic is a relro section for partial and full RELRO
.got is a relro section for partial and full RELRO
.got.plt is a relro section for full RELRO only

Supersedes #45681 (golang.org/cl/312509)

gopherbot · 2023-03-04T23:18:54Z

This PR (HEAD: 1eccb59) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/473495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-03-05T01:56:54Z

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-05T02:02:51Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-05T02:08:22Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-04-09T15:39:36Z

This PR (HEAD: b0d175e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/473495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-12-16T10:45:38Z

This PR (HEAD: 8c570d3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/473495.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-16T11:25:09Z

Message from Nick Revin:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-19T06:21:33Z

Message from qiulaidongfeng:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-19T06:21:33Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-19T06:34:39Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-19T15:21:32Z

Message from Cherry Mui:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T22:09:56Z

Message from Nick Revin:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T22:10:04Z

This PR (HEAD: effcd7b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/473495.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-09T22:17:17Z

This PR (HEAD: 2cacbec) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/473495.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-09T22:24:25Z

Message from Nick Revin:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T19:53:09Z

This PR (HEAD: 771f575) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/473495.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-31T19:59:21Z

Message from Nick Revin:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T19:58:59Z

Message from Cherry Mui:

Patch Set 6: Commit-Queue+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T19:58:59Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-01T19:45:17Z","revision":"616ded201847757774587b6ae4601dcdf0a067ec"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T20:11:17Z

Message from Cherry Mui:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T20:11:17Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T20:11:18Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-05T19:38:23Z

This PR (HEAD: 89abef2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/473495.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-05T19:51:33Z

Message from Nick Revin:

Patch Set 6:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-05T20:18:05Z

Message from Cherry Mui:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-06T18:24:25Z

This PR (HEAD: 52543a7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/473495.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-06T18:43:22Z

Message from Nick Revin:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-06T20:33:22Z

Message from Cherry Mui:

Patch Set 8: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-06T20:39:31Z

Message from Gopher Robot:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-16T15:59:59Z

Message from Gopher Robot:

Patch Set 13:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-16T18:49:25Z

Message from Gopher Robot:

Patch Set 13: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

-bindnow linker option enables full RELRO on ELF targets. This options defaults to false and preserves current behavior - partial relro for buildmode=pie. Also, the following changes were made to align internal linker's behavior with external ELF linkers: - GNU_RELRO segment is marked Read-only - .dynamic is a relro section for partial and full RELRO - .got is a relro section for partial and full RELRO - .got.plt is a relro section for full RELRO only Supersedes #45681 (golang.org/cl/312509)

gopherbot · 2024-02-26T19:54:36Z

Message from Nick Revin:

Patch Set 13:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T19:54:46Z

This PR (HEAD: bc68264) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/473495.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-27T18:47:54Z

Message from Cherry Mui:

Patch Set 14: Code-Review+2 Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T18:47:55Z

Message from Go LUCI:

Patch Set 14:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-27T18:36:56Z","revision":"104c477d5e555d38411df395de8c659544834ad0"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T18:47:55Z

Message from Gopher Robot:

Patch Set 14:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T19:00:17Z

Message from Cherry Mui:

Patch Set 14: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T19:00:17Z

Message from Go LUCI:

Patch Set 14:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T19:00:18Z

Message from Go LUCI:

Patch Set 14: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T21:37:03Z

Message from Gopher Robot:

Patch Set 14: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-28T03:17:29Z

Message from Nick Revin:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-29T04:45:07Z

Message from Nick Revin:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-29T14:50:26Z

Message from Than McIntosh:

Patch Set 14: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

-bindnow linker option enables full RELRO on ELF targets. This options defaults to false and preserves current behavior - partial relro for buildmode=pie. Also, the following changes were made to align internal linker's behavior with external ELF linkers: - GNU_RELRO segment is marked Read-only - .dynamic is a relro section for partial and full RELRO - .got is a relro section for partial and full RELRO - .got.plt is a relro section for full RELRO only Supersedes #45681 (golang.org/cl/312509) Change-Id: I51c4ef07b14beceb7cd6fd989f323e45f89a63ca GitHub-Last-Rev: bc68264 GitHub-Pull-Request: #58869 Reviewed-on: https://go-review.googlesource.com/c/go/+/473495 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Run-TryBot: Cherry Mui <[email protected]> Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

gopherbot · 2024-02-29T16:47:33Z

Message from Cherry Mui:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/473495.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-29T16:54:11Z

This PR is being closed because golang.org/cl/473495 has been merged.

-bindnow linker option enables full RELRO on ELF targets. This options defaults to false and preserves current behavior - partial relro for buildmode=pie. Also, the following changes were made to align internal linker's behavior with external ELF linkers: - GNU_RELRO segment is marked Read-only - .dynamic is a relro section for partial and full RELRO - .got is a relro section for partial and full RELRO - .got.plt is a relro section for full RELRO only Supersedes #45681 (golang.org/cl/312509) Change-Id: I51c4ef07b14beceb7cd6fd989f323e45f89a63ca GitHub-Last-Rev: bc6826441065395b80a2b66cde67466c4d9bce2e GitHub-Pull-Request: golang/go#58869 Reviewed-on: https://go-review.googlesource.com/c/go/+/473495 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Run-TryBot: Cherry Mui <[email protected]> Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

nrvnrvn mentioned this pull request May 20, 2023

proposal: cmd/link: add option to enable full RELRO for ELF #60318

Closed

nrvnrvn added 9 commits February 26, 2024 17:27

add tests

bf1fa87

use internal linker explicitly

917d654

tests: use proper testenv checks

f239244

add tests for external linkmode

782f798

fix freebsd tests

bfb4af1

fix one sub-test

8c85e98

leave only one test for external linker

a5d4ea7

check dynamic bind now flags for external linkers less strictly

bc68264

gopherbot closed this Feb 29, 2024

nrvnrvn deleted the full-relro branch March 4, 2024 07:15

cmd/link: add option to enable full RELRO for ELF #58869

cmd/link: add option to enable full RELRO for ELF #58869

Conversation

nrvnrvn commented Mar 4, 2023

gopherbot commented Mar 4, 2023

gopherbot commented Mar 5, 2023

gopherbot commented Mar 5, 2023

gopherbot commented Mar 5, 2023

gopherbot commented Apr 9, 2023

gopherbot commented Dec 16, 2023

gopherbot commented Dec 16, 2023

gopherbot commented Dec 19, 2023

gopherbot commented Dec 19, 2023

gopherbot commented Dec 19, 2023

gopherbot commented Dec 19, 2023

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Jan 31, 2024

gopherbot commented Feb 1, 2024

gopherbot commented Feb 1, 2024

gopherbot commented Feb 1, 2024

gopherbot commented Feb 1, 2024

gopherbot commented Feb 1, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 5, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 6, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 29, 2024

gopherbot commented Feb 29, 2024

gopherbot commented Feb 29, 2024

gopherbot commented Feb 29, 2024