use internal linker explicitly

Author: nrvnrvn

src/cmd/link/internal/ld/elf_test.go

@@ -189,30 +189,37 @@ func TestElfBindNow(t *testing.T) {
 	testenv.MustHaveGoBuild(t)
 	testenv.MustInternalLink(t, false)
 
-	const prog = `package main; import _ "net"; func main() {}`
+	const (
+		prog   = `package main; func main() {}`
+		prog_C = `package main; import "C"; func main() {}`
+	)
 
 	tests := []struct {
 		name          string
 		args          []string
+		prog          string
 		wantDf1Now    bool
 		wantDf1Pie    bool
 		wantDfBindNow bool
 	}{
-		{name: "default"},
+		{name: "default", prog: prog},
 		{
 			name:       "pie",
-			args:       []string{"-buildmode=pie"},
+			args:       []string{"-buildmode=pie", "-ldflags", "-linkmode=internal"},
+			prog:       prog,
 			wantDf1Pie: true,
 		},
 		{
 			name:          "bindnow",
-			args:          []string{"-ldflags", "-bindnow"},
+			args:          []string{"-ldflags", "-bindnow -linkmode=internal"},
+			prog:          prog_C,
 			wantDf1Now:    true,
 			wantDfBindNow: true,
 		},
 		{
 			name:          "bindnow-pie",
-			args:          []string{"-buildmode=pie", "-ldflags", "-bindnow"},
+			args:          []string{"-buildmode=pie", "-ldflags", "-bindnow -linkmode=internal"},
+			prog:          prog,
 			wantDf1Now:    true,
 			wantDf1Pie:    true,
 			wantDfBindNow: true,
@@ -230,61 +237,59 @@ func TestElfBindNow(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		t.Run(
-			test.name, func(t *testing.T) {
-				var (
-					gotDfBindNow, gotDf1Now, gotDf1Pie bool
-
-					dir     = t.TempDir()
-					src     = filepath.Join(dir, fmt.Sprintf("elf_%s.go", test.name))
-					binFile = filepath.Join(dir, test.name)
-				)
-
-				if err := os.WriteFile(src, []byte(prog), 0666); err != nil {
-					t.Fatal(err)
-				}
-
-				cmdArgs := append([]string{"build", "-o", binFile}, append(test.args, src)...)
-				cmd := testenv.Command(t, testenv.GoToolPath(t), cmdArgs...)
-
-				if out, err := cmd.CombinedOutput(); err != nil {
-					t.Fatalf("%v: %v:\n%s", cmd.Args, err, out)
-				}
-
-				fi, err := os.Open(binFile)
-				if err != nil {
-					t.Fatalf("failed to open built file: %v", err)
-				}
-				defer fi.Close()
-
-				elfFile, err := elf.NewFile(fi)
-				if err != nil {
-					t.Skip("The system may not support ELF, skipped.")
-				}
-				defer elfFile.Close()
-
-				flags, err := elfFile.DynValue(elf.DT_FLAGS)
-				if err != nil {
-					t.Fatalf("failed to get DT_FLAGS: %v", err)
-				}
-
-				flags1, err := elfFile.DynValue(elf.DT_FLAGS_1)
-				if err != nil {
-					t.Fatalf("failed to get DT_FLAGS_1: %v", err)
-				}
-
-				if gotDfBindNow = gotDynFlag(flags, uint64(elf.DF_BIND_NOW)); gotDfBindNow != test.wantDfBindNow {
-					t.Fatalf("DT_FLAGS BIND_NOW flag is %v, want: %v", gotDfBindNow, test.wantDfBindNow)
-				}
-
-				if gotDf1Now = gotDynFlag(flags1, uint64(elf.DF_1_NOW)); gotDf1Now != test.wantDf1Now {
-					t.Fatalf("DT_FLAGS_1 DF_1_NOW flag is %v, want: %v", gotDf1Now, test.wantDf1Now)
-				}
-
-				if gotDf1Pie = gotDynFlag(flags1, uint64(elf.DF_1_PIE)); gotDf1Pie != test.wantDf1Pie {
-					t.Fatalf("DT_FLAGS_1 DF_1_PIE flag is %v, want: %v", gotDf1Pie, test.wantDf1Pie)
-				}
-			},
-		)
+		t.Run(test.name, func(t *testing.T) {
+			var (
+				gotDfBindNow, gotDf1Now, gotDf1Pie bool
+
+				dir     = t.TempDir()
+				src     = filepath.Join(dir, fmt.Sprintf("elf_%s.go", test.name))
+				binFile = filepath.Join(dir, test.name)
+			)
+
+			if err := os.WriteFile(src, []byte(test.prog), 0666); err != nil {
+				t.Fatal(err)
+			}
+
+			cmdArgs := append([]string{"build", "-o", binFile}, append(test.args, src)...)
+			cmd := testenv.Command(t, testenv.GoToolPath(t), cmdArgs...)
+
+			if out, err := cmd.CombinedOutput(); err != nil {
+				t.Fatalf("failed to build %v: %v:\n%s", cmd.Args, err, out)
+			}
+
+			fi, err := os.Open(binFile)
+			if err != nil {
+				t.Fatalf("failed to open built file: %v", err)
+			}
+			defer fi.Close()
+
+			elfFile, err := elf.NewFile(fi)
+			if err != nil {
+				t.Skip("The system may not support ELF, skipped.")
+			}
+			defer elfFile.Close()
+
+			flags, err := elfFile.DynValue(elf.DT_FLAGS)
+			if err != nil {
+				t.Fatalf("failed to get DT_FLAGS: %v", err)
+			}
+
+			flags1, err := elfFile.DynValue(elf.DT_FLAGS_1)
+			if err != nil {
+				t.Fatalf("failed to get DT_FLAGS_1: %v", err)
+			}
+
+			if gotDfBindNow = gotDynFlag(flags, uint64(elf.DF_BIND_NOW)); gotDfBindNow != test.wantDfBindNow {
+				t.Fatalf("DT_FLAGS BIND_NOW flag is %v, want: %v", gotDfBindNow, test.wantDfBindNow)
+			}
+
+			if gotDf1Now = gotDynFlag(flags1, uint64(elf.DF_1_NOW)); gotDf1Now != test.wantDf1Now {
+				t.Fatalf("DT_FLAGS_1 DF_1_NOW flag is %v, want: %v", gotDf1Now, test.wantDf1Now)
+			}
+
+			if gotDf1Pie = gotDynFlag(flags1, uint64(elf.DF_1_PIE)); gotDf1Pie != test.wantDf1Pie {
+				t.Fatalf("DT_FLAGS_1 DF_1_PIE flag is %v, want: %v", gotDf1Pie, test.wantDf1Pie)
+			}
+		})
 	}
 }