fmt: display contained values when formatting atomic booleans and integers #54744

jamespwilliams · 2022-08-29T16:54:16Z

treat atomic.{Int32,Int64,Uint32,Uint64} values as integers when
formatting, using the underlying integer value (by calling Load). This
has the effect of, for example, formatting an atomic integer type
containing 42 as "42", not "{{}, 42}".
treat atomic.Bool values as booleans when formatting, using the
contained boolean value (by calling Load). This has the effect of, for
example, formatting a true atomic.Bool value containing as "true",
not "{{}, 1}" or "{{} %!t(uint32=1)}" as before.

…egers * treat `atomic.{Int32,Int64,Uint32,Uint64}` values as integers when formatting, using the underlying integer value (by calling Load). This has the effect of, for example, formatting an atomic integer type containing 42 as "42", not "{{}, 42}"). * treat `atomic.Bool` values as booleans when formatting, using the contained boolean value (by calling Load). This has the effect of, for example, formatting an true atomic.Bool value containing as "true", not "{{}, 1}" or "{{} %!t(uint32=1)}" as before. Fixes golang#54731

google-cla · 2022-08-29T16:54:19Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2022-08-29T16:59:53Z

This PR (HEAD: a9ee026) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/426456 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-08-29T17:04:20Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.