cmd/compile: avoid excessive libfuzzer instrumentation of int compares #53786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

kyakdan wants to merge 1 commit into golang:master from CodeIntelligenceTesting:fix-excessive-libfuzzer-instrumentation

Contributor

kyakdan commented Jul 11, 2022

Do not intercept integer compares that are used to increment libFuzzer's
8-bit counters. This is unnecessary and has a negative impact on the
fuzzing performance. This fixes #53760.


          cmd/compile: avoid excessive libfuzzer instrumentation of int compares

52f69fd

Do not intercept integer compares that are used to increment libFuzzer's
8-bit counters. This is unnecessary and has a negative impact on the
fuzzing performance. This fixes golang#53760.

Contributor

gopherbot commented Jul 11, 2022

This PR (HEAD: 52f69fd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/416796 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Aug 30, 2022

Message from Keith Randall:

Patch Set 1: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 30, 2022

Message from Keith Randall:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 30, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 30, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 30, 2022

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 30, 2022

Message from Keith Randall:

Patch Set 1: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 30, 2022

Message from Keith Randall:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 30, 2022

Message from Gopher Robot:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Aug 30, 2022

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/416796.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          cmd/compile: avoid excessive libfuzzer instrumentation of int compares

6b113c0

Do not intercept integer compares that are used to increment libFuzzer's
8-bit counters. This is unnecessary and has a negative impact on the
fuzzing performance. This fixes #53760.

Change-Id: Id22efac968b18014eedabb6f0762e1456897024e
GitHub-Last-Rev: 52f69fd
GitHub-Pull-Request: #53786
Reviewed-on: https://go-review.googlesource.com/c/go/+/416796
Run-TryBot: Keith Randall <[email protected]>
Auto-Submit: Keith Randall <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>

Contributor

gopherbot commented Aug 31, 2022

This PR is being closed because golang.org/cl/416796 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet