net/http: fix memory leak in http.Transport #50799
Conversation
|
This PR (HEAD: 891f3d3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/380674 to see it. Tip: You can toggle comments from me using the |
|
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/380674. |
|
Message from Julien SALLEYRON: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/380674. |
|
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/380674. |
The wantConnQueue keeps reference on wantConn which keeps reference on the request context until the next request for the same key. This can be a problem if you never do another request with the same key. So now, we force the clean of the idleConnWait/connsPerHostWait after returning the response or error for a getConn.
juliens
force-pushed
the
fix/transport-memory-leak
branch
from
891f3d3 to
cfb09a0
Compare
|
This PR (HEAD: cfb09a0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/380674 to see it. Tip: You can toggle comments from me using the |
|
Message from Alexander Yastrebov: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/380674. |
|
Message from [email protected]: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/380674. |
The wantConnQueue keeps reference on wantConn which keeps reference on
the request context until the next request for the same key.
This can be a problem if you never have another request with the same key.
So now, we clean the idleConnWait/connsPerHostWait after returning the
response or error for a getConn.
Fixes #50798