-
Notifications
You must be signed in to change notification settings - Fork 18.4k
crypto/x509: add new FreeBSD 12.2+ trusted certificate folder #46276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: f927ca9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/321190 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Tobias Klauser: Patch Set 3: Run-TryBot+1 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Tobias Klauser: Patch Set 3: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Go Bot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Go Bot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Filippo Valsorda: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Up to FreeBSD 12.1 the package ca_root_nss was needed in order to have certificates under /usr/local/share/certs as the base system didn't have a system-wide trusted certificate store. This has been created in FreeBSD 12.2 in /etc/ssl/certs: https://svnweb.freebsd.org/base?view=revision&revision=357082 Fixes golang#46284
This PR (HEAD: 0fa5542) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/321190 to see it. Tip: You can toggle comments from me using the |
Message from Filippo Valsorda: Patch Set 5: Run-TryBot+1 Code-Review+2 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Go Bot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Go Bot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Go Bot: Patch Set 5: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Go Bot: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Message from Go Bot: Patch Set 5: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/321190. |
Up to FreeBSD 12.1 the package ca_root_nss was needed in order to have certificates under /usr/local/share/certs as the base system didn't have a system trusted certificate store. This has been fixed in FreeBSD 12.2 using /etc/ssl/certs: https://svnweb.freebsd.org/base?view=revision&revision=357082 Fixes #46284 Change-Id: I912b1bacc30cdf20d19e3ef9d09b69bb8055ff49 GitHub-Last-Rev: 0fa5542 GitHub-Pull-Request: #46276 Reviewed-on: https://go-review.googlesource.com/c/go/+/321190 Reviewed-by: Filippo Valsorda <[email protected]> Run-TryBot: Filippo Valsorda <[email protected]> TryBot-Result: Go Bot <[email protected]> Trust: Tobias Klauser <[email protected]>
This PR is being closed because golang.org/cl/321190 has been merged. |
Up to FreeBSD 12.1 the package ca_root_nss was needed in order to have certificates under /usr/local/share/certs as the base system didn't have a system trusted certificate store. This has been fixed in FreeBSD 12.2 using /etc/ssl/certs: https://svnweb.freebsd.org/base?view=revision&revision=357082 Fixes #46284 Change-Id: I912b1bacc30cdf20d19e3ef9d09b69bb8055ff49 GitHub-Last-Rev: 0fa5542ea3c70ecb03e621381d7c34fbadf7ea47 GitHub-Pull-Request: golang/go#46276 Reviewed-on: https://go-review.googlesource.com/c/go/+/321190 Reviewed-by: Filippo Valsorda <[email protected]> Run-TryBot: Filippo Valsorda <[email protected]> TryBot-Result: Go Bot <[email protected]> Trust: Tobias Klauser <[email protected]>
Up to FreeBSD 12.1 the package ca_root_nss was needed in order to have
certificates under /usr/local/share/certs as the base system didn't have
a system trusted certificate store.
This has been fixed in FreeBSD 12.2 using /etc/ssl/certs:
https://svnweb.freebsd.org/base?view=revision&revision=357082
Fixes #46284