cmd/buildid: move and reuse duplicated HashToString code to cmd/internal/buildid/buildid #42052

proggga · 2020-10-18T17:06:54Z

No description provided.

gopherbot · 2020-10-18T17:21:21Z

This PR (HEAD: f902014) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-18T17:23:21Z

This PR (HEAD: 86b7ab2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-18T17:25:21Z

This PR (HEAD: 9c58a96) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-26T19:04:13Z

Message from Emmanuel Odeke:

Patch Set 3: Run-TryBot+1

(10 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-26T19:06:12Z

Message from Go Bot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5ac4b6f3

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-26T19:17:48Z

Message from Go Bot:

Patch Set 3:

Build is still in progress...
This change failed on (x/tools) linux-amd64:
See https://storage.googleapis.com/go-build-log/5ac4b6f3/linux-amd64_1c90634a.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-26T19:41:00Z

Message from Go Bot:

Patch Set 3: TryBot-Result-1

1 of 20 TryBots failed:
Failed on (x/tools) linux-amd64: https://storage.googleapis.com/go-build-log/5ac4b6f3/linux-amd64_1c90634a.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-26T22:07:35Z

This PR (HEAD: 43cbf78) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-26T22:09:38Z

This PR (HEAD: aa06841) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-27T10:58:40Z

This PR (HEAD: c3cb682) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-27T11:11:35Z

Message from Emmanuel Odeke:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-27T11:11:35Z

Message from Go Bot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ff4602d0

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-27T11:19:29Z

Message from Go Bot:

Patch Set 7:

Build is still in progress...
This change failed on (x/tools) linux-amd64:
See https://storage.googleapis.com/go-build-log/ff4602d0/linux-amd64_4bcd31c8.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-27T11:21:33Z

This PR (HEAD: 781dbf9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-27T11:23:32Z

Message from Go Bot:

Patch Set 7: TryBot-Result-1

1 of 20 TryBots failed:
Failed on (x/tools) linux-amd64: https://storage.googleapis.com/go-build-log/ff4602d0/linux-amd64_4bcd31c8.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-27T11:51:34Z

Message from Mikhail Fesenko:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-27T18:06:02Z

Message from Emmanuel Odeke:

Patch Set 8: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-27T18:06:03Z

Message from Go Bot:

Patch Set 8:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5df6d84b

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-27T18:20:28Z

Message from Go Bot:

Patch Set 8: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T18:06:56Z

Message from Jay Conrod:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T18:12:43Z

Message from Mikhail Fesenko:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T18:20:36Z

Message from Mikhail Fesenko:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T18:35:46Z

Message from Jay Conrod:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T18:41:45Z

This PR (HEAD: a47614d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-28T18:49:41Z

Message from Mikhail Fesenko:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T18:51:47Z

This PR (HEAD: fa8e891) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-28T20:25:03Z

Message from Jay Conrod:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

…nal/buildid/buildid Change-Id: Iff5682f20f33130bbe4302d867c45e682717e039

gopherbot · 2020-10-28T20:35:30Z

This PR (HEAD: c01db43) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-28T20:39:10Z

Message from Mikhail Fesenko:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T20:52:27Z

Message from Jay Conrod:

Patch Set 11: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T20:52:27Z

Message from Go Bot:

Patch Set 11:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=9c6ace11

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T21:04:57Z

Message from Go Bot:

Patch Set 11: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T21:20:02Z

Message from Jay Conrod:

Patch Set 11: Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263418.
After addressing review feedback, remember to publish your drafts!

…nal/buildid/buildid Change-Id: I1e1ac770d4aac12d7d7ec57ef95f77a3e14a678c GitHub-Last-Rev: c01db43 GitHub-Pull-Request: #42052 Reviewed-on: https://go-review.googlesource.com/c/go/+/263418 Run-TryBot: Jay Conrod <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Jay Conrod <[email protected]> Trust: Jay Conrod <[email protected]> Trust: Michael Matloob <[email protected]>

gopherbot · 2020-10-28T21:55:09Z

This PR is being closed because golang.org/cl/263418 has been merged.

proggga · 2020-10-28T22:06:31Z

Please add 'hacktoberfest-approved'

google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 18, 2020

proggga force-pushed the remove_duplicate_code branch from f902014 to 86b7ab2 Compare October 18, 2020 17:21

proggga force-pushed the remove_duplicate_code branch from 86b7ab2 to 9c58a96 Compare October 18, 2020 17:24

proggga force-pushed the remove_duplicate_code branch from 9c58a96 to 43cbf78 Compare October 26, 2020 22:06

proggga force-pushed the remove_duplicate_code branch from 43cbf78 to aa06841 Compare October 26, 2020 22:08

proggga changed the title ~~cmd/buildid: move code duplicate to cmd/internal/buildid/buildid~~ cmd/buildid: move and reuse duplicated HashToString code to cmd/internal/buildid/buildid Oct 27, 2020

proggga force-pushed the remove_duplicate_code branch from aa06841 to c3cb682 Compare October 27, 2020 10:57

proggga force-pushed the remove_duplicate_code branch from c3cb682 to 781dbf9 Compare October 27, 2020 11:21

proggga force-pushed the remove_duplicate_code branch from 781dbf9 to a47614d Compare October 28, 2020 18:39

proggga force-pushed the remove_duplicate_code branch from a47614d to fa8e891 Compare October 28, 2020 18:50

cmd/buildid: move and reuse duplicated HashToString code to cmd/inter…

c01db43

…nal/buildid/buildid Change-Id: Iff5682f20f33130bbe4302d867c45e682717e039

proggga force-pushed the remove_duplicate_code branch from fa8e891 to c01db43 Compare October 28, 2020 20:34

gopherbot closed this Oct 28, 2020

proggga deleted the remove_duplicate_code branch October 28, 2020 23:01

cmd/buildid: move and reuse duplicated HashToString code to cmd/internal/buildid/buildid #42052

cmd/buildid: move and reuse duplicated HashToString code to cmd/internal/buildid/buildid #42052

Uh oh!

Conversation

proggga commented Oct 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 18, 2020

Uh oh!

gopherbot commented Oct 18, 2020

Uh oh!

gopherbot commented Oct 18, 2020

Uh oh!

gopherbot commented Oct 26, 2020

Uh oh!

gopherbot commented Oct 26, 2020

Uh oh!

gopherbot commented Oct 26, 2020

Uh oh!

gopherbot commented Oct 26, 2020

Uh oh!

gopherbot commented Oct 26, 2020

Uh oh!

gopherbot commented Oct 26, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 27, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

proggga commented Oct 28, 2020

Uh oh!

Uh oh!

proggga commented Oct 18, 2020 •

edited

Loading