-
Notifications
You must be signed in to change notification settings - Fork 18.1k
net/http: remove DualStack in DefaultTransport #41233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removing `DualStack` from `http.DefaultTransport` since it is deprecated. https://github.com/golang/go/blob/master/src/net/dial.go#L61
This PR (HEAD: 0907b59) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/253198 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/253198. |
Message from Ananya Saxena: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/253198. |
This comment has been minimized.
This comment has been minimized.
Message from Damien Neil: Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/253198. |
Message from Go Bot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=f2bc2e33 Please don’t reply on this GitHub thread. Visit golang.org/cl/253198. |
Message from Brad Fitzpatrick: Patch Set 1: Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/253198. |
Removing `DualStack` from `http.DefaultTransport` since it is deprecated https://github.com/golang/go/blob/master/src/net/dial.go#L61 Change-Id: Id8ea1e68796ef8a8d49f7a04d0c4815aa92a1804 GitHub-Last-Rev: 0907b59 GitHub-Pull-Request: #41233 Reviewed-on: https://go-review.googlesource.com/c/go/+/253198 Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> Trust: Damien Neil <[email protected]> Trust: Brad Fitzpatrick <[email protected]>
This PR is being closed because golang.org/cl/253198 has been merged. |
Removing
DualStack
fromhttp.DefaultTransport
since it is deprecatedhttps://github.com/golang/go/blob/master/src/net/dial.go#L61