Skip to content

cmd/internal/objfile: cache computation of goobj.Arch #40877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cmd/internal/objfile: cache computation of goobj.Arch #40877

wants to merge 1 commit into from

Conversation

qingyunha
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 19, 2020
@qingyunha
Copy link
Contributor Author

Reopen the RP due to a bug of GerritBot #40874

@gopherbot
Copy link
Contributor

This PR (HEAD: ca8cae2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/249180 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Keith Randall:

Patch Set 1: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/249180.
After addressing review feedback, remember to publish your drafts!

@qingyunha qingyunha changed the title Implement an unresolved TODO to cache goobj.Arch. cmd/internal/objfile: cache computation of goobj.Arch Aug 19, 2020
@gopherbot
Copy link
Contributor

Message from 陶青云:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/249180.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Keith Randall:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/249180.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=541bfc56

Please don’t reply on this GitHub thread. Visit golang.org/cl/249180.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/249180.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 19, 2020
@qingyunha @randall77
cmd/internal/objfile: cache computation of goobj.Arch
31da1d9 
Change-Id: I23774cf185e5fa6b89398001cd0655fb0c5bdb46
GitHub-Last-Rev: ca8cae2
GitHub-Pull-Request: #40877
Reviewed-on: https://go-review.googlesource.com/c/go/+/249180
Run-TryBot: Keith Randall <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/249180 has been merged.

@gopherbot gopherbot closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingyunha @gopherbot @googlebot