os: do not use procfs for os.Executable in dragonfly #36826

tuxillo · 2020-01-28T11:17:04Z

procfs(5) is not always mounted in DragonFly BSD, for example during
the binary package build with synth. os.Executable() consumers
will then fail, we've spotted this when trying to build tinygo:

[...]

copying source files
./build/tinygo build-builtins -target=armv6m-none-eabi [...]
panic: could not get executable path: readlink /proc/curproc/file:
no such file or directory

[...]

Use KERN_PROC_PATHNAME as FreeBSD does.

gopherbot · 2020-01-28T11:19:25Z

This PR (HEAD: 851c4e4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/216622 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-28T15:19:26Z

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

This will be for 1.15.

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-28T17:43:03Z

Message from Antonio Huete Jimenez:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-28T17:44:15Z

Message from Antonio Huete Jimenez:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-28T18:28:13Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-28T18:28:24Z

This PR (HEAD: d6b2146) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/216622 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-28T18:33:23Z

Message from Antonio Huete Jimenez:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-28T19:48:25Z

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Thanks, looks reasonable. Leaving for 1.15.

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-01-28T21:46:12Z

This PR (HEAD: b85c923) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/216622 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-01-28T21:47:41Z

Message from Antonio Huete Jimenez:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-07T01:08:52Z

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

pd0h

Hi

gopherbot · 2020-10-28T10:39:34Z

Message from Tobias Klauser:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T11:14:46Z

Message from Antonio Huete Jimenez:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T11:14:46Z

Message from Antonio Huete Jimenez:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

procfs(5) is not always mounted in DragonFly BSD, for example during the binary package build with synth. os.Executable() consumers will then fail, we've spotted this when trying to build tinygo: [...] copying source files ./build/tinygo build-builtins -target=armv6m-none-eabi [...] panic: could not get executable path: readlink /proc/curproc/file: no such file or directory [...] Use KERN_PROC_PATHNAME as FreeBSD does.

gopherbot · 2020-10-28T11:44:31Z

This PR (HEAD: 083120a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/216622 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-28T11:48:19Z

Message from Antonio Huete Jimenez:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T12:13:56Z

Message from Tobias Klauser:

Patch Set 5: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T12:15:49Z

Message from Go Bot:

Patch Set 5:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=a8432d35

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T12:36:30Z

Message from Go Bot:

Patch Set 5: TryBot-Result+1

SlowBots are happy.
SlowBot builds that ran:

dragonfly-amd64
dragonfly-amd64-5_8

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-28T12:47:52Z

Message from Tobias Klauser:

Patch Set 5: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/216622.
After addressing review feedback, remember to publish your drafts!

procfs(5) is not always mounted in DragonFly BSD, for example during the binary package build with synth. os.Executable() consumers will then fail, we've spotted this when trying to build tinygo: [...] copying source files ./build/tinygo build-builtins -target=armv6m-none-eabi [...] panic: could not get executable path: readlink /proc/curproc/file: no such file or directory [...] Use KERN_PROC_PATHNAME as FreeBSD does. Change-Id: Ic65bea02cd0309fb24dec8ba8d2b151d1acde67b GitHub-Last-Rev: 083120a GitHub-Pull-Request: #36826 Reviewed-on: https://go-review.googlesource.com/c/go/+/216622 Run-TryBot: Tobias Klauser <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> Trust: Brad Fitzpatrick <[email protected]>

gopherbot · 2020-10-28T17:10:25Z

This PR is being closed because golang.org/cl/216622 has been merged.

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 28, 2020

tuxillo force-pushed the dragonfly-os-executable branch from 851c4e4 to d6b2146 Compare January 28, 2020 18:27

tuxillo force-pushed the dragonfly-os-executable branch from d6b2146 to b85c923 Compare January 28, 2020 21:45

This comment has been minimized.

Sign in to view

pd0h approved these changes Jun 23, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

gopherbot force-pushed the master branch from a408139 to 5764653 Compare September 14, 2020 21:26

tuxillo force-pushed the dragonfly-os-executable branch from b85c923 to 083120a Compare October 28, 2020 11:43

gopherbot closed this Oct 28, 2020

os: do not use procfs for os.Executable in dragonfly #36826

os: do not use procfs for os.Executable in dragonfly #36826

Uh oh!

Conversation

tuxillo commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented Jan 28, 2020

Uh oh!

gopherbot commented May 7, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pd0h left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

gopherbot commented Oct 28, 2020

Uh oh!

Uh oh!

tuxillo commented Jan 28, 2020 •

edited

Loading