Skip to content

net: fix typo in unexported variable name #36237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mark-rushakoff
Copy link
Contributor

@mark-rushakoff mark-rushakoff commented Dec 20, 2019

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Dec 20, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 27373f6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/212300 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

Thanks. I guess this should wait for 1.15 at this point.


Please don’t reply on this GitHub thread. Visit golang.org/cl/212300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=fbbb6482


Please don’t reply on this GitHub thread. Visit golang.org/cl/212300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/212300.
After addressing review feedback, remember to publish your drafts!

@mark-rushakoff
Copy link
Contributor Author

@odeke-em can this PR be merged now? Thanks.

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 1: Code-Review+2

(1 comment)

Thank you for catching this Mark! LGTM with a minor nit but also please rebase from master and then I’ll run the trybots and on passing, I shall then merge it in.


Please don’t reply on this GitHub thread. Visit golang.org/cl/212300.
After addressing review feedback, remember to publish your drafts!

@mark-rushakoff mark-rushakoff force-pushed the fix-misbehaving-error-var-name branch from 27373f6 to ba550c5 Compare February 27, 2020 05:20
@gopherbot
Copy link
Contributor

This PR (HEAD: ba550c5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/212300 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 2: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/212300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=fe3e0abb


Please don’t reply on this GitHub thread. Visit golang.org/cl/212300.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 27, 2020
Change-Id: Idf64716ef8cc3ceee2fc94462cba33ba60049f7b
GitHub-Last-Rev: ba550c5
GitHub-Pull-Request: #36237
Reviewed-on: https://go-review.googlesource.com/c/go/+/212300
Run-TryBot: Emmanuel Odeke <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/212300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/212300 has been merged.

@gopherbot gopherbot closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants