Skip to content

os: allow case only renames on case-insensitive filesystems #35298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

os: allow case only renames on case-insensitive filesystems #35298

wants to merge 1 commit into from

Conversation

AudriusButkevicius
Copy link
Contributor

Fixes #35222

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 31, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 3a935d5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/204601 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 954a016) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/204601 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/204601.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Audrius Butkevicius:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/204601.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 1, 2019
@AudriusButkevicius @ianlancetaylor
os: allow case only renames on case-insensitive filesystems
4a09a9b 
Fixes #35222

Change-Id: I8be45092ac4079d21ff54661637a3aa8ec4eb9bc
GitHub-Last-Rev: 954a016
GitHub-Pull-Request: #35298
Reviewed-on: https://go-review.googlesource.com/c/go/+/204601
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/204601.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=bbc47ce0

Please don’t reply on this GitHub thread. Visit golang.org/cl/204601.
After addressing review feedback, remember to publish your drafts!

@AudriusButkevicius AudriusButkevicius deleted the fix-35222 branch November 1, 2019 00:17
@AudriusButkevicius AudriusButkevicius mentioned this pull request Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os: Case-only renames not possible on case insensitive filesystems
3 participants
@AudriusButkevicius @gopherbot @googlebot