net/http: change TimeoutHandler's docs to match its new interfaces #33770
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: c18ab61) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/191237 to see it. Tip: You can toggle comments from me using the |
|
Message from Bryan C. Mills: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/191237. |
|
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=62c68820 Please don’t reply on this GitHub thread. Visit golang.org/cl/191237. |
|
Message from Bryan C. Mills: Patch Set 1: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/191237. |
|
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/191237. |
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and this change corrects its documentation to say that. Fixes golang#33769 Updates golang#29193
jmhodges
force-pushed
the
doc_timeouthandler
branch
from
c18ab61 to
5310d2c
Compare
|
This PR (HEAD: 5310d2c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/191237 to see it. Tip: You can toggle comments from me using the |
|
Message from Jeff Hodges: Patch Set 3:
Done! Please don’t reply on this GitHub thread. Visit golang.org/cl/191237. |
|
Message from Andrew Bonventre: Patch Set 3: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/191237. |
|
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=742bd992 Please don’t reply on this GitHub thread. Visit golang.org/cl/191237. |
|
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/191237. |
|
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=61581bda Please don’t reply on this GitHub thread. Visit golang.org/cl/191169. |
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and this change corrects its documentation to say that. Fixes #33769 Updates #29193 Change-Id: Ia0523f7f2e3dc1f8f0b68950b85a7bf81c4abe60 GitHub-Last-Rev: 5310d2c GitHub-Pull-Request: #33770 Reviewed-on: https://go-review.googlesource.com/c/go/+/191237 Reviewed-by: Andrew Bonventre <[email protected]> Run-TryBot: Andrew Bonventre <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
|
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/191169. |
|
Message from Bryan C. Mills: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/191169. |
…ch its new interfaces As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and this change corrects its documentation to say that. Fixes #33769 Updates #29193 Change-Id: Ia0523f7f2e3dc1f8f0b68950b85a7bf81c4abe60 GitHub-Last-Rev: 5310d2c GitHub-Pull-Request: #33770 Reviewed-on: https://go-review.googlesource.com/c/go/+/191237 Reviewed-by: Andrew Bonventre <[email protected]> Run-TryBot: Andrew Bonventre <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> (cherry picked from commit f3e3b71) Reviewed-on: https://go-review.googlesource.com/c/go/+/191169 Reviewed-by: Bryan C. Mills <[email protected]>
|
This PR is being closed because golang.org/cl/191169 has been merged. |
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and this change corrects its documentation to say that. Fixes golang#33769 Updates golang#29193 Change-Id: Ia0523f7f2e3dc1f8f0b68950b85a7bf81c4abe60 GitHub-Last-Rev: 5310d2c GitHub-Pull-Request: golang#33770 Reviewed-on: https://go-review.googlesource.com/c/go/+/191237 Reviewed-by: Andrew Bonventre <[email protected]> Run-TryBot: Andrew Bonventre <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
As of Go 1.13rc1, TimeoutHandler supports the Flusher and Pusher interfaces and
this change corrects its documentation to say that.
Fixes #33769
Updates #29193