math: use Sincos instead of Sin and Cos in Jn and Yn #31019
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: eb9ed7d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/169078 to see it. Tip: You can toggle comments from me using the |
|
Message from Neven Sajko: Patch Set 1: This was benchmarked on a Linux amd64 on a i5-8300H. The benchmark results are strange, but I guess they can be ignored because it is clear from the diff this should be a positive change. Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Robert Griesemer: Patch Set 1: (3 comments) LGTM but I have some suggestions. Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
This should be slightly faster. Benchmarks: name old time/op new time/op delta Jn-8 108ns ± 0% 109ns ± 0% +0.93% (p=0.000 n=20+16) Yn-8 106ns ± 0% 106ns ± 0% ~ (all equal)
|
This PR (HEAD: 7c3d813) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/169078 to see it. Tip: You can toggle comments from me using the |
|
Message from Robert Griesemer: Patch Set 2: Run-TryBot+1 LGTM but please only mention the relevant benchmarks in the CL description. Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=29db3015 Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Gobot Gobot: Patch Set 2: Build is still in progress... Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report. Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Gobot Gobot: Patch Set 2: TryBot-Result-1 1 of 19 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Neven Sajko: Patch Set 2:
The commit message in the Github commit after the force-push has only two benchmarks, but it seems that did not propagate to Gerrit. Should I edit the commit message directly in the Gerrit interface? Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Brad Fitzpatrick: Patch Set 2:
No. See https://github.com/golang/go/wiki/CommitMessage#github-pull-requests Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Neven Sajko: Patch Set 3:
OK, sorry about that. It should be OK now. Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Robert Griesemer: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Neven Sajko: Patch Set 3: (1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
Message from Robert Griesemer: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
Change-Id: I0da3857013f1d4e90820fb043314d78924113a27 GitHub-Last-Rev: 7c3d813 GitHub-Pull-Request: #31019 Reviewed-on: https://go-review.googlesource.com/c/go/+/169078 Reviewed-by: Robert Griesemer <[email protected]>
|
Message from Robert Griesemer: Patch Set 4: Code-Review+2 LGTM. Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/169078. |
|
This PR is being closed because golang.org/cl/169078 has been merged. |
No description provided.