-
Notifications
You must be signed in to change notification settings - Fork 18.4k
cmd/cgo: add missing parameter list for function _cgo_wait_runtime_init_done #29900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 186863a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/159178 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/159178. |
Message from Ian Lance Taylor: Patch Set 1: R=go1.13 Please don’t reply on this GitHub thread. Visit golang.org/cl/159178. |
Message from Philipp Stephani: Patch Set 1: Code-Review+1 Not sure why I'm set as reviewer, but LGTM ;) Please don’t reply on this GitHub thread. Visit golang.org/cl/159178. |
Message from Emmanuel Odeke: Patch Set 1: Run-TryBot+1 Code-Review+1 Thank you for this change Philipp! Technically this shouldn't be a problem but I wonder if running this IIRC foo() and foo(void) could be interchangeable but with Anyways, I'll defer to Ian for the final LGTM! Please don’t reply on this GitHub thread. Visit golang.org/cl/159178. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=d842bf84 Please don’t reply on this GitHub thread. Visit golang.org/cl/159178. |
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/159178. |
Message from Philipp Stephani: Patch Set 1:
I think this is extremely unlikely. This only affects an internal function; to trigger the behavior you describe the old implementation would have to define and call the function with the correct (undeclared) arguments, without anybody noticing the non-matching declaration. Please don’t reply on this GitHub thread. Visit golang.org/cl/159178. |
…it_done Fixes #29879 Change-Id: Id2061a5eab67bb90a8116dc4f16073be1c9a09a9 GitHub-Last-Rev: 186863a GitHub-Pull-Request: #29900 Reviewed-on: https://go-review.googlesource.com/c/go/+/159178 Reviewed-by: Philipp Stephani <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Emmanuel Odeke <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
This PR is being closed because golang.org/cl/159178 has been merged. |
Fixes #29879