Skip to content

encoding/json: add comment for mashalererror struct #29752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

encoding/json: add comment for mashalererror struct #29752

wants to merge 3 commits into from

Conversation

GuilhermeCaruso
Copy link
Contributor

@GuilhermeCaruso GuilhermeCaruso commented Jan 15, 2019 •
edited
Loading

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 15, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 3cbd8dd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157958 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157958.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/157958.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 19ea6fb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157958 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please do update the description, by editing the title and first comment of the pull request. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157958.
After addressing review feedback, remember to publish your drafts!

@GuilhermeCaruso GuilhermeCaruso changed the title encoding/json: Added comment for MashalerError struct encoding/json: Adjust comment for MashalerError struct Jan 15, 2019
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/157958.
After addressing review feedback, remember to publish your drafts!

@GuilhermeCaruso GuilhermeCaruso changed the title encoding/json: Adjust comment for MashalerError struct encoding/json: added comment for mashalererror struct Jan 15, 2019
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/157958.
After addressing review feedback, remember to publish your drafts!

@GuilhermeCaruso GuilhermeCaruso changed the title encoding/json: added comment for mashalererror struct encoding/json: add comment for mashalererror struct Jan 15, 2019
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/157958.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 55c91fc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157958 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Jan 15, 2019
@ianlancetaylor
encoding/json: add comment for mashalererror struct
5fae09b 
Change-Id: Iaabbfe5a4c1bbedd19d4087f1b79e5a38bdd3878
GitHub-Last-Rev: 55c91fc
GitHub-Pull-Request: #29752
Reviewed-on: https://go-review.googlesource.com/c/157958
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 9: Code-Review+2

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/157958.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/157958 has been merged.

@gopherbot gopherbot closed this Jan 15, 2019
e-nikolov pushed a commit to e-nikolov/json that referenced this pull request Nov 25, 2021
@ianlancetaylor
encoding/json: add comment for mashalererror struct
53a164c 
Change-Id: Iaabbfe5a4c1bbedd19d4087f1b79e5a38bdd3878
GitHub-Last-Rev: 55c91fc19074dacc66623aa7ff2286b11ccd5340
GitHub-Pull-Request: golang/go#29752
Reviewed-on: https://go-review.googlesource.com/c/157958
Reviewed-by: Ian Lance Taylor <[email protected]>
e-nikolov pushed a commit to e-nikolov/json that referenced this pull request Nov 25, 2021
@ianlancetaylor
encoding/json: add comment for mashalererror struct
97533d8 
Change-Id: Iaabbfe5a4c1bbedd19d4087f1b79e5a38bdd3878
GitHub-Last-Rev: 55c91fc19074dacc66623aa7ff2286b11ccd5340
GitHub-Pull-Request: golang/go#29752
Reviewed-on: https://go-review.googlesource.com/c/157958
Reviewed-by: Ian Lance Taylor <[email protected]>
e-nikolov pushed a commit to e-nikolov/json that referenced this pull request Nov 25, 2021
@ianlancetaylor
encoding/json: add comment for mashalererror struct
f2e36ae 
Change-Id: Iaabbfe5a4c1bbedd19d4087f1b79e5a38bdd3878
GitHub-Last-Rev: 55c91fc19074dacc66623aa7ff2286b11ccd5340
GitHub-Pull-Request: golang/go#29752
Reviewed-on: https://go-review.googlesource.com/c/157958
Reviewed-by: Ian Lance Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuilhermeCaruso @gopherbot @googlebot