Skip to content

Conversation

cn0047
Copy link
Contributor

@cn0047 cn0047 commented Nov 20, 2018

This commit performs replace double quote to backquote,
so now all examples looks consistent.

On reflect documentation page only this function
doesn't have description, this commit add simple description.
This commit adds examples for Match, Find,
FindAllSubmatch, FindSubmatch and Match functions.
This commit adds examples for Match, Find,
FindAllSubmatch, FindSubmatch and Match functions.
This commit adds examples for Match, Find,
FindAllSubmatch, FindSubmatch and Match functions.
This commit performs replace double quote to backquote,
so now all examples looks consistent.
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 20, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: e3e636c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/150397 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Rob Pike:

Patch Set 1: Run-TryBot+1 Code-Review+2

Thank you.


Please don’t reply on this GitHub thread. Visit golang.org/cl/150397.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e979cb7a


Please don’t reply on this GitHub thread. Visit golang.org/cl/150397.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/150397.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 20, 2018
This commit performs replace double quote to backquote,
so now all examples looks consistent.

Change-Id: I8cf760ce1bdeff9619a88e531161b9516385241b
GitHub-Last-Rev: e3e636c
GitHub-Pull-Request: #28879
Reviewed-on: https://go-review.googlesource.com/c/150397
Reviewed-by: Rob Pike <[email protected]>
Run-TryBot: Rob Pike <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/150397 has been merged.

@gopherbot gopherbot closed this Nov 20, 2018
bradfitz pushed a commit that referenced this pull request Nov 21, 2018
This commit performs replace double quote to backquote,
so now all examples looks consistent.

Change-Id: I8cf760ce1bdeff9619a88e531161b9516385241b
GitHub-Last-Rev: e3e636c
GitHub-Pull-Request: #28879
Reviewed-on: https://go-review.googlesource.com/c/150397
Reviewed-by: Rob Pike <[email protected]>
Run-TryBot: Rob Pike <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants