Skip to content

net: Add GetSysfd to conn type of net for getting sysfd for further use #25731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sandyskies
Copy link
Contributor

fix #25729
SetDeadline have a poor performance in the benchmark, maybe because of the timmer.
So I add a function to get the sysfd of the socket, that I can set the specify socket options. I use the following code to set timeout in the socket:
fd = conn.(*net.UDPConn).GetSysfd()
var tv syscall.Timeval
tv.Sec = 1
tv.Usec = 0
err := syscall.SetsockoptTimeval(fd, syscall.SOL_SOCKET, syscall.SO_RCVTIMEO, &tv)

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jun 5, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: a9df438) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/116295 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/116295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Code-Review-2

Thanks, but we are not going to make this change. It will fail badly if you hold onto the file descriptor but drop the Conn. It will not respect the locking protocol used by internal/poll. This implementation won't compile on Windows.


Please don’t reply on this GitHub thread. Visit golang.org/cl/116295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

I should add that you can already set the socket receive timeout via the SyscallConn method; call the Control method of the returned RawConn value.


Please don’t reply on this GitHub thread. Visit golang.org/cl/116295.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 13 times, most recently from 4016de0 to d2f663c Compare July 18, 2018 19:56
@gopherbot gopherbot force-pushed the master branch 10 times, most recently from 9092511 to 95c3348 Compare July 19, 2018 18:17
@gopherbot gopherbot force-pushed the master branch 5 times, most recently from 0090c13 to 8fbbf63 Compare July 28, 2018 01:16
@sandyskies sandyskies closed this Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net: SetDeadline performance is poor
3 participants