x/tools/gopls/internal: OpenFile failures on js/wasm with new 1.24.0 toolchain upgrade of Go 1.23

[gopherbot]

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls` && `call of Value.Call on undefined`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.01s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdba0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x736db00, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x736db00, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7332700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2352761625/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7332700, 0x20c150)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cache" && test == "TestCaseInsensitiveFilesystem"

2025-02-21 15:23 x_tools-go1.23-js-wasm tools@f95771e6 release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.01s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdba0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x736db00, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x736db00, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7332700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2352761625/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7332700, 0x20c150)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

2025-02-21 15:31 x_tools-go1.23-js-wasm tools@8b85edcc release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.01s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdba0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x735bb60, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x735bb60, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7332700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2905470421/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7332700, 0x20c150)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

2025-02-21 18:18 x_tools-go1.23-js-wasm tools@23211ff4 release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.01s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdba0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x736db60, 0x5d}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x736db60, 0x5d}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7332700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2003550856/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7332700, 0x20c150)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

2025-02-21 18:26 x_tools-go1.23-js-wasm tools@f2beb33b release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.01s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdba0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x736bb00, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x736bb00, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7342700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo285859018/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7342700, 0x20c0d0)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

2025-02-21 18:51 x_tools-go1.23-js-wasm tools@7347766e release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.02s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdba0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x735db60, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x735db60, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7332700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo3453834609/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7332700, 0x20c0d0)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

2025-02-21 19:15 x_tools-go1.23-js-wasm tools@4e0c888d release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.01s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdba0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x736bb60, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x736bb60, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7342700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2533098912/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7342700, 0x20c0d0)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cache" && test == "TestCaseInsensitiveFilesystem"

2025-02-21 21:16 x_tools-go1.23-js-wasm tools@1c52ccd3 release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.02s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdd00, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x736bb60, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x736bb60, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7332700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo30943227/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7332700, 0x20c4f0)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

2025-02-21 21:16 x_tools-go1.23-js-wasm tools@6e3d8bca release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.01s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdca0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x736bb60, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x736bb60, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7342700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2443135392/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7342700, 0x20c430)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cache" && test == "TestCaseInsensitiveFilesystem"

2025-02-21 21:47 x_tools-go1.23-js-wasm tools@3d7c2e28 release-branch.go1.23@22fdd35c x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem (log)

=== RUN   TestCaseInsensitiveFilesystem
--- FAIL: TestCaseInsensitiveFilesystem (0.01s)
panic: syscall/js: call of Value.Call on undefined
	panic: syscall/js: call of Value.Call on undefined [recovered]
	panic: syscall/js: call of Value.Call on undefined

goroutine 1573 [running]:
testing.tRunner.func1.2({0xbdca0, 0x12d8780})
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1734 +0x1e
testing.tRunner.func1()
...
os.OpenFile({0x736db60, 0x5e}, 0x241, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:392 +0x3
os.WriteFile({0x736db60, 0x5e}, {0x72efdbc, 0x2, 0x2}, 0x1ff)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/os/file.go:850 +0x2
golang.org/x/tools/gopls/internal/cache.TestCaseInsensitiveFilesystem(0x7332700)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2430739653/gopls/internal/cache/view_test.go:22 +0x13
testing.tRunner(0x7332700, 0x20c430)
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0x12
created by testing.(*T).Run in goroutine 1
	/home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x49

— watchflakes

[findleyr]

@golang/js I'm a bit out of my depth. These failures are only occurring on our 1.23 builder, which is special: gopls always updates its go.mod go version to the latest release of go (1.24, currently). However, we keep the N-1 builders to verify that gopls still integrates with the ambient go version.

So in this case, the gopls integration tests are probably the only case where the test binary is built with (effectively) GOTOOLCHAIN=go1.24.0, and opening files seems to be broken in this configuration.

[johanbrandhorst]

Could this be an interaction between the GOTOOLCHAIN and the move of the wasm/js runtime files from GOROOT/misc/wasm to GOROOT/lib/wasm? Just thinking what else could be causing this, this port is pretty much unchanged in 1.24.