os: (*Cmd).Wait hangs on macOS when setctty is used after commit b15c399a3 #61779
Description
A test that involves setting the command's TTY with the code below, and then calling (*Cmd).Wait, started timing out on macOS in Go 1.20.
func SetCtty(cmd *exec.Cmd, tty *os.File) {
cmd.SysProcAttr = &syscall.SysProcAttr{
Setctty: true,
Setsid: true,
Ctty: 3,
}
cmd.ExtraFiles = []*os.File{tty}
}
I bisected it down to b15c399.
commit b15c399a36a38509ae56dd69670974566f7b0d52
Author: Yuval Pavel Zholkover <[email protected]>
Date: Sat Jul 30 20:41:58 2022 +0300
os: only add file descriptors which are set to non-blocking mode to the netpoller
Either ones where kind == kindNonBlock or those we've successfully called syscall.SetNonblock() on.
Restore blocking behavior if we detect an error registering with the netpoller and our flow was
successful in setting the inital syscall.SetNonblock().
Update #54100
Change-Id: I08934e4107c7fb36c15a7ca23ac880490b4df235
Reviewed-on: https://go-review.googlesource.com/c/go/+/420334
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Goutnik <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Run-TryBot: Yuval Pavel Zholkover <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
src/os/file_unix.go | 32 +++++++++++++++++++++-----------
1 file changed, 21 insertions(+), 11 deletions(-)
You can see the failing tests in the CI of rogpeppe/go-internal#172 (https://github.com/rogpeppe/go-internal/actions/runs/5005273594?pr=172) or in age's tests (https://github.com/FiloSottile/age/actions/runs/5633140339/job/15261730363).