Skip to content

x/vuln: create exp/govulncheck and update cmd/govulncheck to use internal/govulncheck #56042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Oct 4, 2022 · 11 comments
Closed

x/vuln: create exp/govulncheck and update cmd/govulncheck to use internal/govulncheck #56042

julieqiu opened this issue Oct 4, 2022 · 11 comments
Assignees
@zpavlinovic @hyangah @julieqiu
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/2022

Comments

@julieqiu
Copy link
Member

julieqiu commented Oct 4, 2022

Move the logic in govulncheck to internal/govulncheck, and refactor cmd/govulncheck to just use internal/govulncheck.Result:

func Run(ctx context.Context, cfg Config) (*Result, error) { ... }
@julieqiu julieqiu added vulncheck or vulndb Issues for the x/vuln or x/vulndb repo NeedsFix The path to resolution is known, but the work has not been done. labels Oct 4, 2022
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Oct 4, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/437856 mentions this issue: internal/govulncheck: replace vulncheck.Result with Result

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/437865 mentions this issue: cmd,exp,internal: add ctx to Run

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/437864 mentions this issue: exp/govulncheck: change Run to Main

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/439075 mentions this issue: internal/govulncheck: change Run to return Result struct

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/439076 mentions this issue: internal/govulncheck: write TODOs where relevant

gopherbot pushed a commit to golang/vuln that referenced this issue Oct 6, 2022
@julieqiu @gopherbot
exp/govulncheck: change Run to Main
27389ae 
Create a stable API for exp/govulncheck, for use by gopls.

The function signature for exp/govulncheck.Main should not need change
in the process of refactoring internal/govulncheck.

For golang/go#56042

Change-Id: I3c62d9bc3a3e13d80e5693cf8bcb8f8794721e0e
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/437864
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Julie Qiu <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
gopherbot pushed a commit to golang/vuln that referenced this issue Oct 7, 2022
@julieqiu
cmd,exp,internal: add ctx to Run
43dce25 
Run now accepts context.Context as its first argument.

For golang/go#56042

Change-Id: I24b3cbb5b28bf4d6ec55fdbe76af2d80480fa7ab
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/437865
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
gopherbot pushed a commit to golang/vuln that referenced this issue Oct 7, 2022
@julieqiu
internal/govulncheck: change Run to return Result struct
71bb19f 
The function signature for Run is changed to:

func Run(ctx context.Context, cfg Config) (*Result, error) {...}

At the moment, Result is an empty struct. Fields will be added in
subsequent CLs.

For golang/go#56042

Change-Id: I4568ca8147809c0c4e26aa83c96440d16ca32ffb
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/439075
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/vuln that referenced this issue Oct 7, 2022
@julieqiu
internal/govulncheck: write TODOs where relevant
dbe0ff4 
To make it clearer what is happening in subsequent CLs in this stack,
write down TODOs throughout the code.

For golang/go#56042

Change-Id: I1ccb38c53f4edd75ec6f6c2fc7de5ee0d0aba1c3
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/439076
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
@julieqiu julieqiu modified the milestones: vuln/unplanned, vuln/2022 Oct 13, 2022
@julieqiu julieqiu changed the title x/vuln: refactor govulncheck to use internal/govulncheck.Result x/vuln: create exp/govulncheck and update cmd/govulncheck to use internal/govulncheck.Result Oct 17, 2022
@julieqiu julieqiu changed the title x/vuln: create exp/govulncheck and update cmd/govulncheck to use internal/govulncheck.Result x/vuln: create exp/govulncheck and update cmd/govulncheck to use internal/govulncheck Oct 17, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/443070 mentions this issue: internal/govulncheck: add Legacy prefix to legacy structs

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/440219 mentions this issue: exp,internal/govulncheck: add govulncheck API

gopherbot pushed a commit to golang/vuln that referenced this issue Oct 18, 2022
@julieqiu
internal/govulncheck: add Legacy prefix to legacy structs
d0931d2 
We plan to replace structs with a new API design in a follow up CL.

Prefix the legacy structs with Legacy as a first step for this
transition, to make renaming easier.

Also rename run.go to legacy_run.go, since the current implementation of
Run will be replaced by Source and Binary.

For golang/go#56042

Change-Id: I2fc80048bd937ad81ee1263aaac83495ea2e0876
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/443070
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/vuln that referenced this issue Oct 18, 2022
@julieqiu
exp,internal/govulncheck: add govulncheck API
36ca264 
An API is defined for internal/govulncheck.

The API in exp/govulncheck is updated to use internal/govulncheck.Config
and internal/govulncheck.Source.

For golang/go#56042

Change-Id: Ibab2fae0685166e7712b355e2c7c2ab0b4d50c6c
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/440219
Reviewed-by: Jonathan Amsterdam <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/446715 mentions this issue: internal/govulncheck: implement new Source and Binary APIs

gopherbot pushed a commit to golang/vuln that referenced this issue Nov 3, 2022
@zpavlinovic
internal/govulncheck: implement new Source and Binary APIs
f9bfb22 
This is a first in the series of refactoring CLs that implement new
govulncheck API. Please see opening message for more details on actual
changes.

For golang/go#56042

Change-Id: I6ec699204e21e94bf577220bfe040ed6db873d29
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/446715
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/447675 mentions this issue: cmd/govulncheck: update documentation for json flag

gopherbot pushed a commit to golang/vuln that referenced this issue Nov 3, 2022
@zpavlinovic
cmd/govulncheck: update documentation for json flag
6f7a8cb 
Make it point to the new Result data structure.

For golang/go#56042

Change-Id: I4eb1d319c958fef8adcb57adb20840e14f8ca3fa
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/447675
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/447855 mentions this issue: cmd/govulncheck: inline LegacyRun into govulncheck main

softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
internal/govulncheck: change Run to return Result struct
0b07176 
The function signature for Run is changed to:

func Run(ctx context.Context, cfg Config) (*Result, error) {...}

At the moment, Result is an empty struct. Fields will be added in
subsequent CLs.

For golang/go#56042

Change-Id: I4568ca8147809c0c4e26aa83c96440d16ca32ffb
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/439075
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
internal/govulncheck: write TODOs where relevant
ac09bd7 
To make it clearer what is happening in subsequent CLs in this stack,
write down TODOs throughout the code.

For golang/go#56042

Change-Id: I1ccb38c53f4edd75ec6f6c2fc7de5ee0d0aba1c3
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/439076
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
internal/govulncheck: add Legacy prefix to legacy structs
ff566fe 
We plan to replace structs with a new API design in a follow up CL.

Prefix the legacy structs with Legacy as a first step for this
transition, to make renaming easier.

Also rename run.go to legacy_run.go, since the current implementation of
Run will be replaced by Source and Binary.

For golang/go#56042

Change-Id: I2fc80048bd937ad81ee1263aaac83495ea2e0876
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/443070
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
exp,internal/govulncheck: add govulncheck API
4d7016a 
An API is defined for internal/govulncheck.

The API in exp/govulncheck is updated to use internal/govulncheck.Config
and internal/govulncheck.Source.

For golang/go#56042

Change-Id: Ibab2fae0685166e7712b355e2c7c2ab0b4d50c6c
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/440219
Reviewed-by: Jonathan Amsterdam <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
internal/govulncheck: implement new Source and Binary APIs
7a1acac 
This is a first in the series of refactoring CLs that implement new
govulncheck API. Please see opening message for more details on actual
changes.

For golang/go#56042

Change-Id: I6ec699204e21e94bf577220bfe040ed6db873d29
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/446715
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
cmd/govulncheck: update documentation for json flag
1579cb7 
Make it point to the new Result data structure.

For golang/go#56042

Change-Id: I4eb1d319c958fef8adcb57adb20840e14f8ca3fa
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/447675
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
cmd/govulncheck: inline LegacyRun into govulncheck main
d7d53e6 
This is the second in the series of CLs that attempts to refactor
govulncheck. The changes in this CL are:

- inline the logic of LegacyRun into cmd/govulncheck/main.go
- delete LegacyConfig and related data structures
- move all the accompanying logic to cmd/govulncheck
- expose db caching logic

This effectively results in the following structure.
internal/govulncheck contains the core logic for Source and Binary
analysis (including db caching). cmd/govulncheck contains the logic for
parsing the flags and printing the results.

The follow-up refactoring CLs will mainly focus on renaming of things
and addressing TODOs.

For golang/go#56042

Change-Id: Ib1fc26951420ae6d04e48205765a1019d117946f
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/447855
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
all: cleanup govulncheck packages
4d71195 
This CL does not add any new code. It simply

- renames files and moves code accordingly
- makes private those symbols that do not need to be public anymore

For golang/go#56042

Change-Id: I827a84540f0c7200f4d68bf59ce1f6a59a52877f
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/448775
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
exp/govulncheck: change Run to Main
7015e03 
Create a stable API for exp/govulncheck, for use by gopls.

The function signature for exp/govulncheck.Main should not need change
in the process of refactoring internal/govulncheck.

For golang/go#56042

Change-Id: I3c62d9bc3a3e13d80e5693cf8bcb8f8794721e0e
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/437864
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Julie Qiu <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
cmd,exp,internal: add ctx to Run
acb1657 
Run now accepts context.Context as its first argument.

For golang/go#56042

Change-Id: I24b3cbb5b28bf4d6ec55fdbe76af2d80480fa7ab
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/437865
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
internal/govulncheck: change Run to return Result struct
074ef1f 
The function signature for Run is changed to:

func Run(ctx context.Context, cfg Config) (*Result, error) {...}

At the moment, Result is an empty struct. Fields will be added in
subsequent CLs.

For golang/go#56042

Change-Id: I4568ca8147809c0c4e26aa83c96440d16ca32ffb
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/439075
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
internal/govulncheck: write TODOs where relevant
c62a82f 
To make it clearer what is happening in subsequent CLs in this stack,
write down TODOs throughout the code.

For golang/go#56042

Change-Id: I1ccb38c53f4edd75ec6f6c2fc7de5ee0d0aba1c3
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/439076
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
internal/govulncheck: add Legacy prefix to legacy structs
fd3a051 
We plan to replace structs with a new API design in a follow up CL.

Prefix the legacy structs with Legacy as a first step for this
transition, to make renaming easier.

Also rename run.go to legacy_run.go, since the current implementation of
Run will be replaced by Source and Binary.

For golang/go#56042

Change-Id: I2fc80048bd937ad81ee1263aaac83495ea2e0876
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/443070
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
exp,internal/govulncheck: add govulncheck API
3f1d61b 
An API is defined for internal/govulncheck.

The API in exp/govulncheck is updated to use internal/govulncheck.Config
and internal/govulncheck.Source.

For golang/go#56042

Change-Id: Ibab2fae0685166e7712b355e2c7c2ab0b4d50c6c
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/440219
Reviewed-by: Jonathan Amsterdam <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
internal/govulncheck: implement new Source and Binary APIs
207e4d3 
This is a first in the series of refactoring CLs that implement new
govulncheck API. Please see opening message for more details on actual
changes.

For golang/go#56042

Change-Id: I6ec699204e21e94bf577220bfe040ed6db873d29
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/446715
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
cmd/govulncheck: update documentation for json flag
50b1154 
Make it point to the new Result data structure.

For golang/go#56042

Change-Id: I4eb1d319c958fef8adcb57adb20840e14f8ca3fa
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/447675
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
cmd/govulncheck: inline LegacyRun into govulncheck main
3320662 
This is the second in the series of CLs that attempts to refactor
govulncheck. The changes in this CL are:

- inline the logic of LegacyRun into cmd/govulncheck/main.go
- delete LegacyConfig and related data structures
- move all the accompanying logic to cmd/govulncheck
- expose db caching logic

This effectively results in the following structure.
internal/govulncheck contains the core logic for Source and Binary
analysis (including db caching). cmd/govulncheck contains the logic for
parsing the flags and printing the results.

The follow-up refactoring CLs will mainly focus on renaming of things
and addressing TODOs.

For golang/go#56042

Change-Id: Ib1fc26951420ae6d04e48205765a1019d117946f
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/447855
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
all: cleanup govulncheck packages
633f42f 
This CL does not add any new code. It simply

- renames files and moves code accordingly
- makes private those symbols that do not need to be public anymore

For golang/go#56042

Change-Id: I827a84540f0c7200f4d68bf59ce1f6a59a52877f
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/448775
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
exp/govulncheck: change Run to Main
bda39cb 
Create a stable API for exp/govulncheck, for use by gopls.

The function signature for exp/govulncheck.Main should not need change
in the process of refactoring internal/govulncheck.

For golang/go#56042

Change-Id: I3c62d9bc3a3e13d80e5693cf8bcb8f8794721e0e
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/437864
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Julie Qiu <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
cmd,exp,internal: add ctx to Run
4b5d86e 
Run now accepts context.Context as its first argument.

For golang/go#56042

Change-Id: I24b3cbb5b28bf4d6ec55fdbe76af2d80480fa7ab
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/437865
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
internal/govulncheck: change Run to return Result struct
6cfb4d5 
The function signature for Run is changed to:

func Run(ctx context.Context, cfg Config) (*Result, error) {...}

At the moment, Result is an empty struct. Fields will be added in
subsequent CLs.

For golang/go#56042

Change-Id: I4568ca8147809c0c4e26aa83c96440d16ca32ffb
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/439075
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
internal/govulncheck: write TODOs where relevant
e6adabc 
To make it clearer what is happening in subsequent CLs in this stack,
write down TODOs throughout the code.

For golang/go#56042

Change-Id: I1ccb38c53f4edd75ec6f6c2fc7de5ee0d0aba1c3
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/439076
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
internal/govulncheck: add Legacy prefix to legacy structs
ab506b3 
We plan to replace structs with a new API design in a follow up CL.

Prefix the legacy structs with Legacy as a first step for this
transition, to make renaming easier.

Also rename run.go to legacy_run.go, since the current implementation of
Run will be replaced by Source and Binary.

For golang/go#56042

Change-Id: I2fc80048bd937ad81ee1263aaac83495ea2e0876
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/443070
Run-TryBot: Julie Qiu <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
exp,internal/govulncheck: add govulncheck API
d6a8ded 
An API is defined for internal/govulncheck.

The API in exp/govulncheck is updated to use internal/govulncheck.Config
and internal/govulncheck.Source.

For golang/go#56042

Change-Id: Ibab2fae0685166e7712b355e2c7c2ab0b4d50c6c
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/440219
Reviewed-by: Jonathan Amsterdam <[email protected]>
Reviewed-by: Julie Qiu <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Julie Qiu <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
internal/govulncheck: implement new Source and Binary APIs
2aa11b3 
This is a first in the series of refactoring CLs that implement new
govulncheck API. Please see opening message for more details on actual
changes.

For golang/go#56042

Change-Id: I6ec699204e21e94bf577220bfe040ed6db873d29
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/446715
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
cmd/govulncheck: update documentation for json flag
86e3249 
Make it point to the new Result data structure.

For golang/go#56042

Change-Id: I4eb1d319c958fef8adcb57adb20840e14f8ca3fa
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/447675
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
cmd/govulncheck: inline LegacyRun into govulncheck main
1b81ffb 
This is the second in the series of CLs that attempts to refactor
govulncheck. The changes in this CL are:

- inline the logic of LegacyRun into cmd/govulncheck/main.go
- delete LegacyConfig and related data structures
- move all the accompanying logic to cmd/govulncheck
- expose db caching logic

This effectively results in the following structure.
internal/govulncheck contains the core logic for Source and Binary
analysis (including db caching). cmd/govulncheck contains the logic for
parsing the flags and printing the results.

The follow-up refactoring CLs will mainly focus on renaming of things
and addressing TODOs.

For golang/go#56042

Change-Id: Ib1fc26951420ae6d04e48205765a1019d117946f
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/447855
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
all: cleanup govulncheck packages
67b608b 
This CL does not add any new code. It simply

- renames files and moves code accordingly
- makes private those symbols that do not need to be public anymore

For golang/go#56042

Change-Id: I827a84540f0c7200f4d68bf59ce1f6a59a52877f
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/448775
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@golang golang locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zpavlinovic zpavlinovic

@hyangah hyangah

@julieqiu julieqiu

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/2022
Development

No branches or pull requests
4 participants
@zpavlinovic @hyangah @julieqiu @gopherbot