internal/govulncheck: implement new Source and Binary APIs

This is a first in the series of refactoring CLs that implement new
govulncheck API. Please see opening message for more details on actual
changes.

For golang/go#56042

Change-Id: I6ec699204e21e94bf577220bfe040ed6db873d29
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/446715
Run-TryBot: Zvonimir Pavlinovic <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>

Author: softdev050

cmd/govulncheck/main.go

@@ -25,8 +25,7 @@ var (
 	tagsFlag    buildutil.TagsFlag
 
 	// testmode flags. See main_testmode.go.
-	dirFlag         string
-	summaryJSONFlag bool
+	dirFlag string
 )
 
 func init() {
@@ -63,10 +62,7 @@ For details, see https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck.
 	outputType := govulncheck.OutputTypeText
 	if *jsonFlag {
 		outputType = govulncheck.OutputTypeJSON
-	} else if summaryJSONFlag { // accessible only in testmode.
-		outputType = govulncheck.OutputTypeSummary
-	}
-	if outputType == govulncheck.OutputTypeText && *verboseFlag {
+	} else if *verboseFlag {
 		outputType = govulncheck.OutputTypeVerbose
 	}
 

cmd/govulncheck/main_testmode.go

@@ -10,5 +10,4 @@ import "flag"
 
 func init() {
 	flag.StringVar(&dirFlag, "dir", "", "directory to use for loading source files")
-	flag.BoolVar(&summaryJSONFlag, "summary-json", false, "output govulnchecklib.Summary JSON")
 }

cmd/govulncheck/testdata/json-binary.ct

@@ -1,30 +1,10 @@
 $ govulncheck -json ${novuln_binary}
 {
-	"Calls": null,
-	"Imports": null,
-	"Requires": null,
-	"Vulns": null,
-	"Modules": [
-		{
-			"Path": "golang.org/x/text",
-			"Version": "v0.3.7",
-			"Dir": "",
-			"Replace": null
-		},
-		{
-			"Path": "stdlib",
-			"Version": "",
-			"Dir": "",
-			"Replace": null
-		}
-	]
+	"Vulns": null
 }
 
 $ govulncheck -json ${vuln_binary}
 {
-	"Calls": null,
-	"Imports": null,
-	"Requires": null,
 	"Vulns": [
 		{
 			"OSV": {
@@ -87,44 +67,19 @@ $ govulncheck -json ${vuln_binary}
 					}
 				]
 			},
-			"Symbol": "Parse",
-			"PkgPath": "golang.org/x/text/language",
-			"ModPath": "golang.org/x/text",
-			"CallSink": 0,
-			"ImportSink": 0,
-			"RequireSink": 0
-		}
-	],
-	"Modules": [
-		{
-			"Path": "github.com/tidwall/gjson",
-			"Version": "v1.9.2",
-			"Dir": "",
-			"Replace": null
-		},
-		{
-			"Path": "github.com/tidwall/match",
-			"Version": "v1.1.0",
-			"Dir": "",
-			"Replace": null
-		},
-		{
-			"Path": "github.com/tidwall/pretty",
-			"Version": "v1.2.0",
-			"Dir": "",
-			"Replace": null
-		},
-		{
-			"Path": "golang.org/x/text",
-			"Version": "v0.3.0",
-			"Dir": "",
-			"Replace": null
-		},
-		{
-			"Path": "stdlib",
-			"Version": "",
-			"Dir": "",
-			"Replace": null
+			"Modules": [
+				{
+					"Path": "golang.org/x/text",
+					"FoundVersion": "v0.3.0",
+					"FixedVersion": "v0.3.7",
+					"Packages": [
+						{
+							"Path": "golang.org/x/text/language",
+							"CallStacks": null
+						}
+					]
+				}
+			]
 		}
 	]
 }