-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Closed
Labels
FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.SoonThis needs action soon. (recent regressions, service outages, unusual time-sensitive situations)This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.release-blocker
Milestone
Description
CL 349949 updates x/tools/internal/gcimporter/iimport.go to support generics, by porting over changes from the standard library go/internal/gcimporter package. It will take longer to port iexport.go, as it must be translated from cmd/compile/internal/typecheck/iexport.go. In the meantime (~days, I expect), I think we should skip x/tools/go/internal/gcimporter.TestIExportData_stdlib on Go 1.18, in order to avoid failures on the x/tools Trybots on Go repo CLs that use generics.
This issue tracks that process (skipping the test, updating the exporter, and unskipping).
Metadata
Metadata
Assignees
Labels
FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.SoonThis needs action soon. (recent regressions, service outages, unusual time-sensitive situations)This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.release-blocker