x/build/internal/task/releaselet: upgrading Go on windows should prompt with previous installation path

[toothrot]

What version of Go are you using (go version)?

Go 1.16beta1

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

windows-amd64 or windows-386

What did you do?

Installed Go to a custom path via the msi files on https://golang.org/dl. Installed a newer version of Go after that.

What did you expect to see?

I expected the installer to pre-populate my previous installation path in the path field when installing a new version.

What did you see instead?

The default path to install Go populated in the path field in the installation wizard.

Based on @lkarsund's comment here: #42070 (comment)

[cagedmantis]

/cc @golang/release

[nvx]

I just ran into this on Go1.16 release with the Windows amd64 msi installer. Previous versions were installed at C:\Go\ and previous installers defaulted to that location, while the Go1.16 installer unexpectedly defaulted to installing to C:\Program Files\Go\

[cagedmantis]

@nvx the rationale for that change can be found in issue #42070

[gopherbot]

Change https://go.dev/cl/288252 mentions this issue: cmd/release: remember INSTALLDIR on upgrade