gollvm: golang.org/x/mod/semver package is not compiling on Ubuntu 20.04 (Github Actions)

[advancedwebdeveloper]

Hi.
All jobs for https://github.com/advancedwebdeveloper/clang_test_cpu_features/runs/1446453097 failed.
Here is what I see here:

[1497/2668] Building Go package 'golang.org/x/mod/semver' (non-PIC)
FAILED: tools/gollvm/libgo/golang.org/x/mod/semver.o
cd /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/build_release/tools/gollvm/libgo && /usr/local/bin/cmake -E make_directory ./golang.org/x/mod && /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/build_release/./bin/llvm-goc -c -o /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/build_release/tools/gollvm/libgo/golang.org/x/mod/semver.o -fgo-pkgpath=golang.org/x/mod/semver -I . /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/gofrontend/libgo/go/golang.org/x/mod/semver/semver.go

0. Program arguments: /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/build_release/./bin/llvm-goc -c -o /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/build_release/tools/gollvm/libgo/golang.org/x/mod/semver.o -fgo-pkgpath=golang.org/x/mod/semver -I . /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/gofrontend/libgo/go/golang.org/x/mod/semver/semver.go
1. Running pass 'Function Pass Manager' on module 'gomodule'.
2. Running pass 'Combine redundant instructions' on function '@golang_0org_1x_1mod_1semver.parse'
   Segmentation fault (core dumped)

That's coming from Clang 11.

[ianlancetaylor]

I can build the package with gccgo using go build.

I'm not sure how to interpret that output but it looks like a middle-end bug.

[ianlancetaylor]

CC @thanm @cherrymui

[advancedwebdeveloper]

My workflow (Github Actions) could be modified, to trace anything that you would require.
Request anything you want - or try to modify the YAML file, within your own repo.
That could allow to reproduce/check some fault scenarios.

@ianlancetaylor , you didn't explain what should I trace/log.
Anything that I should check, ahead of @thanm's investigation?

[ianlancetaylor]

I'm sorry, I don't know.

[thanm]

Is this a problem only with the Release cmake target? Or do you also see it with DCMAKE_BUILD_TYPE=RelWithDebInfo?

[advancedwebdeveloper]

It might no more be reproducible/no issue present - some errors of another kind are observable, during https://github.com/advancedwebdeveloper/clang_test_cpu_features/actions/runs/395799034

As you can observe in the logs - I caught these errors, while using Clang 9:

[1197/2669] Building CXX object tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoSafeGetg.cpp.o
[1198/2669] Building CXX object tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/RemoveAddrSpace.cpp.o
[1199/2669] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProfWriter.cpp.o
[1200/2669] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProfReader.cpp.o
[1201/2669] Building CXX object tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GC.cpp.o
[1202/2669] Building CXX object tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoAnnotation.cpp.o
[1203/2669] Building CXX object tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoWrappers.cpp.o
[1204/2669] Building CXX object tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o
FAILED: tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o
2020-12-02T10:43:03.8272246Z /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/gollvm/passes -I/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/passes -Iinclude -I/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O2 -g -DNDEBUG -fno-exceptions -fno-rtti -std=c++14 -MD -MT tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o -MF tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o.d -o tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o -c /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/passes/GoNilChecks.cpp /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/passes/GoNilChecks.cpp:361:68: error: no member named 'unknown' in 'llvm::LocationSize'
AA->alias(MemoryLocation(MMO1->getValue(), LocationSize::unknown(),
~~~~~~~~~~~~~~^ /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/passes/GoNilChecks.cpp:363:68: error: no member named 'unknown' in 'llvm::LocationSize'
MemoryLocation(MMO2->getValue(), LocationSize::unknown(),
~~~~~~~~~~~~~~^
2 errors generated.

.
There is a bug, with GCC:

FAILED: lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/CodeGen/AsmPrinter -I/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/lib/CodeGen/AsmPrinter -Iinclude -I/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -O2 -g -DNDEBUG -fno-exceptions -fno-rtti -std=c++14 -MD -MT lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o -MF lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o.d -o lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o -c /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
c++: internal compiler error: Killed (program cc1plus)

. I got the very same bug, as I caught with Clang 9, while using Clang 10:

[1196/2669] Building CXX object tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o
FAILED: tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o
/usr/bin/clang++-10 -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/gollvm/passes -I/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/passes -Iinclude -I/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O2 -g -DNDEBUG -fno-exceptions -fno-rtti -std=c++14 -MD -MT tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o -MF tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o.d -o tools/gollvm/passes/CMakeFiles/LLVMCppGoPasses.dir/GoNilChecks.cpp.o -c /home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/passes/GoNilChecks.cpp
/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/passes/GoNilChecks.cpp:361:68: error: no member named 'unknown' in 'llvm::LocationSize'
AA->alias(MemoryLocation(MMO1->getValue(), LocationSize::unknown(),
/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/passes/GoNilChecks.cpp:363:68: error: no member named 'unknown' in 'llvm::LocationSize'
MemoryLocation(MMO2->getValue(), LocationSize::unknown(),
2 errors generated.
. And the same bug is present with Clang 11, too.

[thanm]

OK, that looks a bit more actionable. I'll send a patch later this morning for the build problem.

For the original issue (crash in Combine redundant instructions) I am able to reproduce that as well, will need to take a closer look.

[gopherbot]

Change https://golang.org/cl/274832 mentions this issue: gollvm: sync with LLVM trunk

[gopherbot]

Change https://golang.org/cl/274833 mentions this issue: gollvm: update recipe for recording SRET arg attribute

[advancedwebdeveloper]

Yes, your patch resolved the last issue.
I tried to re-run the workflow - and (as you can see) various packages are not compiled.
I am unsure what should be logged.

[thanm]

I just submitted 29d8ea6cf9e08a51f89d72dbeca6c0aed4c2016a, that should resolve the llvm-goc runtime error.