Skip to content

doc: release history webpage contains suboptimal links [1.13 backport] #36003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Dec 5, 2019 · 2 comments
Closed

doc: release history webpage contains suboptimal links [1.13 backport] #36003

gopherbot opened this issue Dec 5, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone
Go1.13.6

Comments

@gopherbot
Copy link
Contributor

@dmitshur requested issue #35988 to be considered for backport to the next 1.13 minor release.

@gopherbot, could you please be so kind as to open two backport issues: one for Go 1.13 and another for Go 1.12. This is a documentation fix.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 5, 2019
@gopherbot gopherbot mentioned this issue Dec 5, 2019
Closed
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Dec 5, 2019
@gopherbot gopherbot added this to the Go1.13.6 milestone Dec 5, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/210117 mentions this issue: [release-branch.go1.13] doc: add CherryPickApproved filter to Release History links

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Dec 9, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 9, 2019
gopherbot pushed a commit that referenced this issue Dec 9, 2019
@dmitshur
[release-branch.go1.13] doc: add CherryPickApproved filter to Release…
6bf4b23 
… History links

Not all closed issues in a given minor milestone are included in that
release, only the ones that have been labeled as CherryPickApproved are.

Update the links to the GitHub issue tracker to include a filter on the
CherryPickApproved label, so that the default view shows only the
backports that were included in a given release. This should more useful
to most people than seeing all backports (considered and approved).

Do this only for Go 1.9.1 and newer releases, as that is when we started
using the CherryPickCandidate and CherryPickApproved labels.

Updates #35988
Fixes #36003

Change-Id: I51e07c1bc3ab9c4a5744e8f668c5470adf78bffe
Reviewed-on: https://go-review.googlesource.com/c/go/+/210117
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 6bf4b23 to release-branch.go1.13.

@golang golang locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Milestone
Go1.13.6
Development

No branches or pull requests
2 participants
@toothrot @gopherbot