doc: release history webpage contains suboptimal links #35988
Comments
|
/cc @dmitshur |
|
I agree the current link leads to a page that is hard to read. We shouldn't remove issues from that milestone, because then it will be harder to track history and know what was considered but not accepted. I think a better fix is to add the We've done this for some past releases (e.g., Go 1.12.9, 1.11.14, and 1.10.7) but not all. We need to adjust the release process so this happens for future releases. In the mean time, please use this link: https://github.com/golang/go/issues?q=milestone%3AGo1.13.5+label%3ACherryPickApproved |
dmitshur
added
the
NeedsFix
|
Change https://golang.org/cl/209918 mentions this issue: |
|
I went through the release history a bit. We started consistently using the CherryPickCandidate and CherryPickApproved labels with Go 1.9.1 and later. They weren't used before Go 1.9. I fixed up some minor inconsistencies (i.e., where a change was acutally cherry-picked but its backport issue was missing CherryPickApproved label) in 1.9-1.10; going through 1.11-1.13 releases is still a TODO. Sent CL 209918 to add the |
dmitshur
changed the title
|
@gopherbot, could you please be so kind as to open two backport issues: one for Go 1.13 and another for Go 1.12. This is a documentation fix. |
|
Backport issue(s) opened: #36002 (for 1.12), #36003 (for 1.13). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
|
Change https://golang.org/cl/210117 mentions this issue: |
|
Change https://golang.org/cl/210118 mentions this issue: |
… History links Not all closed issues in a given minor milestone are included in that release, only the ones that have been labeled as CherryPickApproved are. Update the links to the GitHub issue tracker to include a filter on the CherryPickApproved label, so that the default view shows only the backports that were included in a given release. This should more useful to most people than seeing all backports (considered and approved). Do this only for Go 1.9.1 and newer releases, as that is when we started using the CherryPickCandidate and CherryPickApproved labels. Updates #35988 Fixes #36002 Change-Id: I51e07c1bc3ab9c4a5744e8f668c5470adf78bffe Reviewed-on: https://go-review.googlesource.com/c/go/+/210118 Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
… History links Not all closed issues in a given minor milestone are included in that release, only the ones that have been labeled as CherryPickApproved are. Update the links to the GitHub issue tracker to include a filter on the CherryPickApproved label, so that the default view shows only the backports that were included in a given release. This should more useful to most people than seeing all backports (considered and approved). Do this only for Go 1.9.1 and newer releases, as that is when we started using the CherryPickCandidate and CherryPickApproved labels. Updates #35988 Fixes #36003 Change-Id: I51e07c1bc3ab9c4a5744e8f668c5470adf78bffe Reviewed-on: https://go-review.googlesource.com/c/go/+/210117 Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
What did you do?
Opened https://golang.org/doc/devel/release.html#go1.13.minor containing this text:
Followed a link to the GitHub milestone: https://github.com/golang/go/issues?q=milestone%3AGo1.13.5
What did you expect to see?
Issues fixed in 1.13.5.
What did you see instead?
Issues considered for 1.13.5, including the ones that were not backported. For example: #34642
I think either @gopherbot should remove milestone from issues without
CherryPickApprovedlabel after release is done, or link in documentation should include this label.See also #35119 (comment) and below.
The text was updated successfully, but these errors were encountered: