cmd/go: unhelpful go cache error when running in container as non-root user #26280
Description
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10.3 linux/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOOS="linux"
GOARCH="amd64"
What did you do?
Build any go program in a docker image as a user that doesn't exist in the image.
Although this sounds weird, it is specifically allowed in the docker run documentation
When passing a numeric ID, the user does not have to exist in the container.
Any CI server following the principle of least privilege would be configured to run their containers in this way.
Assuming docker is installed, the following command will recreate the issue
docker run -u $UID golang /bin/bash -c "cd /go/src/; mkdir hello; cd hello;
echo 'package main
import \"fmt\"
func main() {
fmt.Println(\"hello world\")
}' > main.go; go run main.go"
More specifically, this is caused when $HOME is set to / which is what docker does in this situation.
What did you expect to see?
hello world
What did you see instead?
go: disabling cache (/.cache/go-build) due to initialization failure: mkdir /.cache: permission denied
hello world
Notes
This is effectively an iteration on #23638. Disabling the cache is probably still the correct thing to do, but in this case, the current error message is unnecessary and more confusing than it is helpful. You can see that confusion in docker-library/golang#225.
As I suggested in my comment on that issue, if go were to silently set GOCHACHE to "off" when $HOME=='/' then this confusion would be avoided. Go already does this when $HOME=='', so I'm just proposing to extend that behavior to one more edge case.
I'm happy to submit a PR that fixes this if you agree with the change.