Skip to content

net: GoLookupIPNoSuchHost performance regression #25336

Closed
@quasilyte

Description

@quasilyte

Commit 672729e (https://golang.org/cl/37879) introduced performance regression for "no such host" case.

goos: linux
goarch: amd64
pkg: net
BenchmarkGoLookupIPNoSuchHost-4               30          43958216 ns/op
BenchmarkGoLookupIPNoSuchHost-4               30          43639313 ns/op
BenchmarkGoLookupIPNoSuchHost-4               30          58653180 ns/op
BenchmarkGoLookupIPNoSuchHost-4               30          49881501 ns/op
BenchmarkGoLookupIPNoSuchHost-4               30          52573745 ns/op

Before that commit:


goos: linux
goarch: amd64
pkg: net
BenchmarkGoLookupIPNoSuchHost-4             2000            681589 ns/op
BenchmarkGoLookupIPNoSuchHost-4             2000            717598 ns/op
BenchmarkGoLookupIPNoSuchHost-4             2000            688904 ns/op
BenchmarkGoLookupIPNoSuchHost-4             2000            690374 ns/op
BenchmarkGoLookupIPNoSuchHost-4             2000            780634 ns/op

In other words:

name                    old time/op  new time/op   delta
GoLookupIPNoSuchHost-4   712µs ±10%  53484µs ±11%  +7413.71%  (p=0.008 n=5+5)

Needs investigation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions