net: use golang.org/x/net/dns/dnsmessage for DNS resolution

Vendors golang.org/x/net/dns/dnsmessage from x/net git rev
892bf7b0c6e2f93b51166bf3882e50277fa5afc6

Updates #16218
Updates #21160

Change-Id: Ic4e8f3c3d83c2936354ec14c5be93b0d2b42dd91
Reviewed-on: https://go-review.googlesource.com/37879
Run-TryBot: Matthew Dempsky <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>

Author: iangudger

src/go/build/deps_test.go

@@ -313,7 +313,7 @@ var pkgDeps = map[string][]string{
 		"context", "math/rand", "os", "reflect", "sort", "syscall", "time",
 		"internal/nettrace", "internal/poll",
 		"internal/syscall/windows", "internal/singleflight", "internal/race",
-		"golang_org/x/net/lif", "golang_org/x/net/route",
+		"golang_org/x/net/dns/dnsmessage", "golang_org/x/net/lif", "golang_org/x/net/route",
 	},
 
 	// NET enables use of basic network-related packages.

src/net/dnsclient.go

@@ -7,6 +7,8 @@ package net
 import (
 	"math/rand"
 	"sort"
+
+	"golang_org/x/net/dns/dnsmessage"
 )
 
 // reverseaddr returns the in-addr.arpa. or ip6.arpa. hostname of the IP
@@ -35,71 +37,13 @@ func reverseaddr(addr string) (arpa string, err error) {
 	return string(buf), nil
 }
 
-// Find answer for name in dns message.
-// On return, if err == nil, addrs != nil.
-func answer(name, server string, dns *dnsMsg, qtype uint16) (cname string, addrs []dnsRR, err error) {
-	addrs = make([]dnsRR, 0, len(dns.answer))
-
-	if dns.rcode == dnsRcodeNameError {
-		return "", nil, &DNSError{Err: errNoSuchHost.Error(), Name: name, Server: server}
-	}
-	if dns.rcode != dnsRcodeSuccess {
-		// None of the error codes make sense
-		// for the query we sent. If we didn't get
-		// a name error and we didn't get success,
-		// the server is behaving incorrectly or
-		// having temporary trouble.
-		err := &DNSError{Err: "server misbehaving", Name: name, Server: server}
-		if dns.rcode == dnsRcodeServerFailure {
-			err.IsTemporary = true
-		}
-		return "", nil, err
-	}
-
-	// Look for the name.
-	// Presotto says it's okay to assume that servers listed in
-	// /etc/resolv.conf are recursive resolvers.
-	// We asked for recursion, so it should have included
-	// all the answers we need in this one packet.
-Cname:
-	for cnameloop := 0; cnameloop < 10; cnameloop++ {
-		addrs = addrs[0:0]
-		for _, rr := range dns.answer {
-			if _, justHeader := rr.(*dnsRR_Header); justHeader {
-				// Corrupt record: we only have a
-				// header. That header might say it's
-				// of type qtype, but we don't
-				// actually have it. Skip.
-				continue
-			}
-			h := rr.Header()
-			if h.Class == dnsClassINET && equalASCIILabel(h.Name, name) {
-				switch h.Rrtype {
-				case qtype:
-					addrs = append(addrs, rr)
-				case dnsTypeCNAME:
-					// redirect to cname
-					name = rr.(*dnsRR_CNAME).Cname
-					continue Cname
-				}
-			}
-		}
-		if len(addrs) == 0 {
-			return "", nil, &DNSError{Err: errNoSuchHost.Error(), Name: name, Server: server}
-		}
-		return name, addrs, nil
-	}
-
-	return "", nil, &DNSError{Err: "too many redirects", Name: name, Server: server}
-}
-
-func equalASCIILabel(x, y string) bool {
-	if len(x) != len(y) {
+func equalASCIIName(x, y dnsmessage.Name) bool {
+	if x.Length != y.Length {
 		return false
 	}
-	for i := 0; i < len(x); i++ {
-		a := x[i]
-		b := y[i]
+	for i := 0; i < int(x.Length); i++ {
+		a := x.Data[i]
+		b := y.Data[i]
 		if 'A' <= a && a <= 'Z' {
 			a += 0x20
 		}

src/net/dnsclient_test.go

@@ -67,51 +67,3 @@ func testWeighting(t *testing.T, margin float64) {
 func TestWeighting(t *testing.T) {
 	testWeighting(t, 0.05)
 }
-
-// Issue 8434: verify that Temporary returns true on an error when rcode
-// is SERVFAIL
-func TestIssue8434(t *testing.T) {
-	msg := &dnsMsg{
-		dnsMsgHdr: dnsMsgHdr{
-			rcode: dnsRcodeServerFailure,
-		},
-	}
-
-	_, _, err := answer("golang.org", "foo:53", msg, uint16(dnsTypeSRV))
-	if err == nil {
-		t.Fatal("expected an error")
-	}
-	if ne, ok := err.(Error); !ok {
-		t.Fatalf("err = %#v; wanted something supporting net.Error", err)
-	} else if !ne.Temporary() {
-		t.Fatalf("Temporary = false for err = %#v; want Temporary == true", err)
-	}
-	if de, ok := err.(*DNSError); !ok {
-		t.Fatalf("err = %#v; wanted a *net.DNSError", err)
-	} else if !de.IsTemporary {
-		t.Fatalf("IsTemporary = false for err = %#v; want IsTemporary == true", err)
-	}
-}
-
-// Issue 12778: verify that NXDOMAIN without RA bit errors as
-// "no such host" and not "server misbehaving"
-func TestIssue12778(t *testing.T) {
-	msg := &dnsMsg{
-		dnsMsgHdr: dnsMsgHdr{
-			rcode:               dnsRcodeNameError,
-			recursion_available: false,
-		},
-	}
-
-	_, _, err := answer("golang.org", "foo:53", msg, uint16(dnsTypeSRV))
-	if err == nil {
-		t.Fatal("expected an error")
-	}
-	de, ok := err.(*DNSError)
-	if !ok {
-		t.Fatalf("err = %#v; wanted a *net.DNSError", err)
-	}
-	if de.Err != errNoSuchHost.Error() {
-		t.Fatalf("Err = %#v; wanted %q", de.Err, errNoSuchHost.Error())
-	}
-}