net/mail: ParseAddress: unclear error message

[kevinburke]

When parsing this address:

mail.ParseAddress("Foo (middle) Bar <foo@example.com>")

you get the following error:

mail: no angle-addr

That's confusing because an angle-addr is present in the input.

The email address should be formatted with quotes as:

mail.ParseAddress(`"Foo (middle) Bar" <foo@example.com>`)

But we could probably be clearer about the error there.

[xmudrii]

Errors seems quite easy to fix. I would like to give it a try, but before, does somebody want to comment on the format.

Should we show how it should be, such as:

incorrect address format, expected `"Foo (middle) Bar" <foo@example.com>`

or just drop a more precise message about error:

incorrect address format

/cc @kevinburke @bradfitz

[ianlancetaylor]

I think neither option is quite right here. It would be best if we could say that the error with the example is a missing quote.

[xmudrii]

@ianlancetaylor i'll try to write some code and push cl, if tests pass, you can expect it.

[gopherbot]

CL https://golang.org/cl/48990 mentions this issue.

[xmudrii]

@ianlancetaylor I hope you've thought about something like this one

[xmudrii]

If anybody wants to take on this, feel free to do. Sorry, I'm out of time for next few days.

[gopherbot]

CL https://golang.org/cl/49410 mentions this issue.

[gopherbot]

CL https://golang.org/cl/50911 mentions this issue.

[guilhermebr]

Calling parseAddres for:
Foo middle Bar <foo@example.com> returns
"Foo middle Bar" <foo@example.com>

and:
"Foo (middle) Bar" <foo@example.com> returns
"Foo (middle) Bar" <foo@example.com>

so I made a change that calling for:
Foo (middle) Bar <foo@example.com> returns
"Foo (middle) Bar" <foo@example.com>
instead of error

[burakguven]

Should this be closed? Since @guilhermebr's change the example given in OP no longer returns an error.