dep init also checks for relative path #549
Conversation
cmd/dep/init.go
Outdated
| func createDirIfNotExist(path string) error { | ||
| if _, err := os.Stat(path); err != nil { | ||
| if os.IsNotExist(err) { | ||
| if e := os.Mkdir(path, os.FileMode(0755)); e != nil { |
There was a problem hiding this comment.
os.MkdirAll here will take care of creating any intermediary directories, if necessary.
Also, let's use 0777 so that it's entirely up to the umask to decide what perms are applied.
cmd/dep/init.go
Outdated
| @@ -68,6 +81,12 @@ func (cmd *initCommand) Run(ctx *dep.Ctx, loggers *Loggers, args []string) error | |||
| root = ctx.WorkingDir | |||
| } else { | |||
| root = args[0] | |||
| if !filepath.IsAbs(args[0]) { | |||
There was a problem hiding this comment.
I think what we really want here is filepath.Clean(). That should do all the work you're manually doing here, plus a little more.
There was a problem hiding this comment.
i checked filepath.Clean(), it doesn't generate absolute path and dep init fails later.
Eg. dep init new_test_project would fail as filepath.clean would return new_test_project as the output.
Let me know if I am missing something.
|
Oh, forgot to mention in my previous review - we'll also want some tests to cover this. |
|
will add tests today. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Fixes #537
*New to golang and this is my first Pull Request.