This repository was archived by the owner on Sep 9, 2020. It is now read-only.
dep: Make noverify preserve excess vendor paths #2002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps handle the not-uncommon case that you might need a metadata file or two in your vendor directory, and you want dep to ignore its existence.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This helps handle the not-uncommon case that you might need a metadata
file or two in your vendor directory, and you want dep to ignore its
existence. Specifying that path with
noverifywilldep ensurenow preserves such files, anddep checkwill honor excess files marked as such.What should your reviewer look out for in this PR?
Any combination of states i missed by making this change?