Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

godep: Import additional packages as required #1640

Merged
merged 3 commits into from
Feb 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion internal/importers/godep/importer.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"log"
"os"
"path/filepath"
"strings"

"github.com/golang/dep"
"github.com/golang/dep/gps"
Expand All @@ -31,7 +32,8 @@ func NewImporter(logger *log.Logger, verbose bool, sm gps.SourceManager) *Import
}

type godepJSON struct {
Imports []godepPackage `json:"Deps"`
Required []string `json:"Packages"`
Imports []godepPackage `json:"Deps"`
}

type godepPackage struct {
Expand Down Expand Up @@ -113,5 +115,14 @@ func (g *Importer) convert(pr gps.ProjectRoot) (*dep.Manifest, *dep.Lock) {
}

g.ImportPackages(packages, true)
required := make([]string, 0, len(g.json.Required))
for _, req := range g.json.Required {
if !strings.HasPrefix(req, ".") { // ignore project packages
required = append(required, req)
}
}
if len(required) > 0 {
g.Manifest.Required = required
}
return g.Manifest, g.Lock
}
16 changes: 16 additions & 0 deletions internal/importers/godep/importer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,22 @@ func TestGodepConfig_Convert(t *testing.T) {
},
},
},
"package with requirements": {
importertest.TestCase{
WantRequired: []string{importertest.Project},
},
godepJSON{
Required: []string{importertest.Project},
},
},
"package with local requirements": {
importertest.TestCase{
WantRequired: nil,
},
godepJSON{
Required: []string{"./..."},
},
},
}

for name, testCase := range testCases {
Expand Down
6 changes: 6 additions & 0 deletions internal/importers/importertest/testcase.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type TestCase struct {
WantRevision gps.Revision
WantVersion string
WantIgnored []string
WantRequired []string
WantWarning string
}

Expand Down Expand Up @@ -71,6 +72,11 @@ func (tc TestCase) validate(manifest *dep.Manifest, lock *dep.Lock, output *byte
manifest.Ignored, tc.WantIgnored)
}

if !equalSlice(manifest.Required, tc.WantRequired) {
return errors.Errorf("unexpected set of required projects: \n\t(GOT) %#v \n\t(WNT) %#v",
manifest.Required, tc.WantRequired)
}

wantConstraintCount := 0
if tc.WantConstraint != "" {
wantConstraintCount = 1
Expand Down