This repository was archived by the owner on Sep 9, 2020. It is now read-only.
godep: Import additional packages as required #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure what the test failure is, but it doesn't seem related? |
|
Yeeaaaah, sorry about that! Ignore the failed test, it's on our end. |
carolynvs
suggested changes
Feb 10, 2018
There was a problem hiding this comment.
Nice! I didn't know this about Godep. 👍
Would you please add unit test(s) to ./internal/importers/godep/importer_test.go verifying your change?
TestGodepConfig_Convert doesn't currently have a "WantRequired" in its testcase structure, so you can either add that to our test case structure and verify it, or feel free to add a new unit test to that file to check that the required package is set properly, and that it ignores local packages.
Thanks!
This mirrors what is done for ignored, as both fields are similar.
We expect to map non-local Packages in godep manifest to required entries in dep.
In a godep manifest, entries in Packages are commonly used to specify extra dependencies of a project, like tools (code generators for example). Adding those same packages to dep's "required" entry achieves the same.
sigma
force-pushed
the
pr/godep-import-packages
branch
from
8b61ed5 to
6130237
Compare
|
@carolynvs thanks for pointing me to the right corner of |
carolynvs
approved these changes
Feb 13, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
In a godep manifest, entries in Packages are commonly used to specify extra
dependencies of a project, like tools (code generators for example).
Adding those same packages to dep's "required" entry achieves the same.
This hopefully reduces the number of manual tweaks to Gopkg.toml before a migration is "complete".